fix: schema for the host option
#3549
Conversation
alexander-akait
requested review from
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3549 +/- ##
==========================================
+ Coverage 93.53% 94.00% +0.46%
==========================================
Files 18 18
Lines 1284 1284
Branches 431 431
==========================================
+ Hits 1201 1207 +6
+ Misses 77 71 -6
Partials 6 6
Continue to review full report at Codecov.
|
| "anyOf": [ | ||
| { | ||
| "enum": ["local-ip", "local-ipv4", "local-ipv6"] | ||
| }, | ||
| { | ||
| "type": "string", | ||
| "minLength": 1 | ||
| } | ||
| ] |
There was a problem hiding this comment.
schema-utils should respect parentSchema.link/description, if we don't have link/description for children.
| - options.host should be a non-empty string. | ||
| -> Allows to specify a hostname to use. | ||
| -> Read more at https://webpack.js.org/configuration/dev-server/#devserverhost" | ||
| - options.host should be a non-empty string." | ||
| `; |
There was a problem hiding this comment.
I see the link is not showing only happening with non-empty error.
There was a problem hiding this comment.
Yep, it should be fixed in schema-utils
There was a problem hiding this comment.
I think we can merge it as is and update snapshots after fixing it in schema utils
For Bugs and Features; did you add new tests?
Existing
Motivation / Use-Case
fix schema
Breaking Changes
No
Additional Info
Also update options for CLI