Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show deprecation warning for incorrect usage of Node.js API #3563

Merged
merged 5 commits into from Aug 6, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP ON TESTS

Motivation / Use-Case

SHOW DEPRECATION WARNING

Breaking Changes

NO

Additional Info

NO

lib/Server.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #3563 (1d60b1e) into master (4480a9e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3563      +/-   ##
==========================================
+ Coverage   94.40%   94.42%   +0.01%     
==========================================
  Files          15       15              
  Lines        1270     1274       +4     
  Branches      440      440              
==========================================
+ Hits         1199     1203       +4     
  Misses         65       65              
  Partials        6        6              
Impacted Files Coverage Δ
lib/Server.js 94.56% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4480a9e...1d60b1e. Read the comment docs.

@snitin315 snitin315 marked this pull request as ready for review July 24, 2021 04:29
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix tests today

@snitin315 snitin315 merged commit 62b21ff into master Aug 6, 2021
@snitin315 snitin315 deleted the api-dep-warn branch August 6, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants