fix(overlay): render ansi formattet error messages correctly #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raix
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #3579 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 15 15
Lines 1274 1274
Branches 440 440
=======================================
Hits 1201 1201
Misses 67 67
Partials 6 6 Continue to review full report at Codecov.
|
|
Seems to be an issue with the test suite... |
githoniel
added a commit
to gem-mine/webpack-dev-server
that referenced
this pull request
Aug 9, 2021
…ansi_html_formatting_the_error_output
|
Will fix the flaky test in other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes, added a test to replicate the issue / cover ansi formatting
Motivation / Use-Case
Fixes the ansi formatting in the overlay - want to use the overlay in the CRA project see #3575 for more info an ways to replicate
Breaking Changes
none
Additional Info
fixed #3575