Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow array for headers option #3847

Merged
merged 8 commits into from Sep 16, 2021
Merged

feat: allow array for headers option #3847

merged 8 commits into from Sep 16, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Sep 15, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

allow array for headers option :-

          headers: [
            {
              key: "X-Foo",
              value: "value1",
            },
            {
              key: "X-Bar",
              value: "value2",
            },
          ],

Breaking Changes

None

Additional Info

No

@snitin315 snitin315 changed the title Headers array feat: allow array for headers option Sep 15, 2021
@snitin315 snitin315 marked this pull request as ready for review September 15, 2021 09:05
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #3847 (f2a2d9c) into master (71da079) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
+ Coverage   92.70%   92.72%   +0.02%     
==========================================
  Files          14       14              
  Lines        1329     1334       +5     
  Branches      466      467       +1     
==========================================
+ Hits         1232     1237       +5     
  Misses         89       89              
  Partials        8        8              
Impacted Files Coverage Δ
lib/Server.js 93.64% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71da079...f2a2d9c. Read the comment docs.

lib/Server.js Outdated Show resolved Hide resolved
rishabh3112
rishabh3112 previously approved these changes Sep 16, 2021
lib/Server.js Outdated Show resolved Hide resolved
Co-authored-by: Alexander Akait <4567934+alexander-akait@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants