refactor(client): make use of ESM instead of CJS #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
commented
Jun 4, 2019
| import { | ||
| clear as clearOverlay, | ||
| showMessage as showMessageOverlay, | ||
| } from './overlay'; |
There was a problem hiding this comment.
* as overlay is prohibited by eslint.
alexander-akait
previously approved these changes
Jun 4, 2019
|
I checked using samples and there was no problem. Let's see how it goes for a while. |
Codecov Report
@@ Coverage Diff @@
## next #1967 +/- ##
==========================================
- Coverage 92.47% 92.35% -0.12%
==========================================
Files 28 28
Lines 1076 1060 -16
Branches 322 322
==========================================
- Hits 995 979 -16
Misses 77 77
Partials 4 4
Continue to review full report at Codecov.
|
|
I think CJS// ts
import * as socket from 'webpack-dev-server/client/socket'ESMdepends on settings of tsconfig // ts
import socket from 'webpack-dev-server/client/socket'So, we will either change to the corresponding both style or change to the next branch. Anyway, I attached the label to block merging. |
wizardofhogwarts
approved these changes
Jun 5, 2019
|
@evilebottnawi please approve if possible |
alexander-akait
approved these changes
Jun 5, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 7, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 10, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 15, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 15, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 15, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 15, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 24, 2019
hiroppy
added a commit
that referenced
this pull request
Jun 24, 2019
knagaitsev
pushed a commit
to knagaitsev/webpack-dev-server
that referenced
this pull request
Jul 31, 2019
hiroppy
added a commit
that referenced
this pull request
Aug 1, 2019
hiroppy
added a commit
that referenced
this pull request
Aug 2, 2019
hiroppy
added a commit
that referenced
this pull request
Aug 5, 2019
hiroppy
added a commit
that referenced
this pull request
Sep 10, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 12, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 18, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 19, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 23, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 24, 2019
alexander-akait
pushed a commit
that referenced
this pull request
Jan 29, 2020
alexander-akait
pushed a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
related #1950
Breaking Changes
no
Additional Info