refactor(server): remove some variables of options #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #2175 +/- ##
=========================================
- Coverage 93.57% 93.47% -0.1%
=========================================
Files 33 33
Lines 1245 1242 -3
Branches 363 365 +2
=========================================
- Hits 1165 1161 -4
- Misses 71 72 +1
Partials 9 9
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Aug 5, 2019
hiroppy
force-pushed
the
feature/refactor-server
branch
from
462015e
to
44a18b3
Compare
hiroppy
added a commit
that referenced
this pull request
Sep 10, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 12, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 18, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 19, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 23, 2019
hiroppy
added a commit
that referenced
this pull request
Dec 24, 2019
alexander-akait
pushed a commit
that referenced
this pull request
Jan 29, 2020
alexander-akait
pushed a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
https://github.com/webpack/webpack-dev-server/projects/1#card-22549444
Breaking Changes
yes
Additional Info
no