feat(server): add stdin option to API #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
hiroppy
requested changes
Aug 10, 2019
test/cli/cli.test.js
Outdated
| ); | ||
| const childProcess = testBin(false, configPath, true); | ||
|
|
||
| setTimeout(() => { |
There was a problem hiding this comment.
plz use timer. await timer(500)
test/cli/cli.test.js
Outdated
| childProcess.stdin.pause(); | ||
| }, 500); | ||
|
|
||
| setTimeout(() => { |
test/cli/cli.test.js
Outdated
| ); | ||
| const childProcess = testBin('--stdin', configPath); | ||
|
|
||
| setTimeout(() => { |
Codecov Report
@@ Coverage Diff @@
## next #2186 +/- ##
==========================================
+ Coverage 93.47% 96.05% +2.57%
==========================================
Files 33 34 +1
Lines 1242 1191 -51
Branches 365 346 -19
==========================================
- Hits 1161 1144 -17
+ Misses 72 46 -26
+ Partials 9 1 -8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## next #2186 +/- ##
==========================================
+ Coverage 93.47% 96.05% +2.57%
==========================================
Files 33 34 +1
Lines 1242 1191 -51
Branches 365 346 -19
==========================================
- Hits 1161 1144 -17
+ Misses 72 46 -26
+ Partials 9 1 -8
Continue to review full report at Codecov.
|
hiroppy
approved these changes
Aug 10, 2019
|
Need to update documentation. |
hiroppy
pushed a commit
that referenced
this pull request
Sep 10, 2019
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
6 tasks
hiroppy
pushed a commit
that referenced
this pull request
Dec 12, 2019
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
hiroppy
pushed a commit
that referenced
this pull request
Dec 18, 2019
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
hiroppy
pushed a commit
that referenced
this pull request
Dec 19, 2019
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
hiroppy
pushed a commit
that referenced
this pull request
Dec 23, 2019
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
hiroppy
pushed a commit
that referenced
this pull request
Dec 24, 2019
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
alexander-akait
pushed a commit
that referenced
this pull request
Jan 29, 2020
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
alexander-akait
pushed a commit
that referenced
this pull request
Jan 31, 2020
* feat(server): add stdin for api * test(stdin): switch to async await tests for stdin * test(cli): use await timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
This makes stdin an option for both CLI and API, and helps in moving configuration changes out of the CLI for CLI refactor.
Same PR as #2106, but moved to
next. It was faster to do this than an ugly rebase.Breaking Changes
None,
stdinwill work the same as it did before on CLI.Additional Info