have --open use the options.public path if it exists #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdwain
commented
Jan 18, 2017
| protocol: protocol, | ||
| hostname: options.host, | ||
| port: options.socket ? 0 : options.port.toString() | ||
| }); | ||
|
|
||
| if(options.inline !== false) { | ||
| const devClient = [`${require.resolve("../client/")}?${options.public ? `${protocol}://${options.public}` : domain}`]; |
There was a problem hiding this comment.
this line behaves the same, but domain is also used on line 375 to calculate the url that gets opened, and that's where the behavior changes
|
@SpaceK33z Is there anything else you wanted done for this? |
|
@bdwain, I am planning to merge this after the 2.2 release (2.2 has been published but not yet with the |
|
cool! |
SpaceK33z
approved these changes
Feb 1, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the --open flag to open the browser to the --public url if it is specified. (the default will be the host like before).
The original issue is #739 , though it will also address #725 by letting you specify localhost as the --public url.
This is not a breaking change.
This is also addressed for version 1 with #748