-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy previews on each PR #2954
Comments
@anshumanv IMO integrating Netlify is not required. |
Just added an integration with netlify, lets see if it works for new PRs outside of my own. For myself looks like its building my own pr now: #2955 |
Too complex in comparison to visiting a link. Also no "integration" as such. 😄
Build seems to be failing now, looking at the logs! @EugeneHlushko |
@EugeneHlushko what's the build setting that you're using? I just deployed my fork and seems to work instantly - https://webpack-docs.netlify.com/ |
It works: #2953 |
Awesome! <3 |
Can we setup deploy previews on each PR to quickly review the changes?
Netlify can do this pretty quickly, all we need to do it add the repo on it and it will provide a preview link on each PR.
@EugeneHlushko @montogeek
The text was updated successfully, but these errors were encountered: