Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy previews on each PR #2954

Closed
anshumanv opened this issue Apr 19, 2019 · 6 comments
Closed

Deploy previews on each PR #2954

anshumanv opened this issue Apr 19, 2019 · 6 comments

Comments

@anshumanv
Copy link
Member

Can we setup deploy previews on each PR to quickly review the changes?

Netlify can do this pretty quickly, all we need to do it add the repo on it and it will provide a preview link on each PR.

@EugeneHlushko @montogeek

@pranshuchittora
Copy link
Member

@anshumanv IMO integrating Netlify is not required.
Because you can achieve something similar to this in VSCode. Read this

@EugeneHlushko
Copy link
Member

Just added an integration with netlify, lets see if it works for new PRs outside of my own. For myself looks like its building my own pr now: #2955

@anshumanv
Copy link
Member Author

anshumanv commented Apr 19, 2019

@anshumanv IMO integrating Netlify is not required.
Because you can achieve something similar to this in VSCode. Read this

Too complex in comparison to visiting a link. Also no "integration" as such. 😄

Just added an integration with netlify, lets see if it works for new PRs outside of my own. For myself looks like its building my own pr now: #2955

Build seems to be failing now, looking at the logs! @EugeneHlushko

@anshumanv
Copy link
Member Author

anshumanv commented Apr 19, 2019

@EugeneHlushko what's the build setting that you're using? I just deployed my fork and seems to work instantly - https://webpack-docs.netlify.com/
image

@EugeneHlushko
Copy link
Member

It works: #2953
Had to fine tune it, ty for suggesting, feel free to close

@anshumanv
Copy link
Member Author

Awesome! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants