Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Updates and Fixes #225

Merged
merged 54 commits into from
Oct 15, 2016
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
2a5ebe9
Cleaning up font directory, adding geomanist and cabin, and breaking …
skipjack Oct 10, 2016
2c37ebe
Using new fonts in the logo, headers, and body text
skipjack Oct 10, 2016
49383e1
Removing various backgrounds in body content
skipjack Oct 10, 2016
7562d81
Removing the 40px padding for now (might have to come back to the sid…
skipjack Oct 10, 2016
b6fc76c
Simplifying the color scheme using @jhnns new logo colors and updatin…
skipjack Oct 10, 2016
f6c908e
Adding react-headroom and updating the navigation component (@bebraw …
skipjack Oct 10, 2016
1e0c59b
Simplifying the contributors section
skipjack Oct 10, 2016
9e6d257
Fixing parts of the page layout after recent changes
skipjack Oct 10, 2016
fdf1f79
Pointing users to develop instead of master so they see the most rece…
skipjack Oct 10, 2016
b9ccd3a
Cleaning up the sidebar styling
skipjack Oct 10, 2016
a33a92a
Updating padding for mobile page__content
skipjack Oct 10, 2016
0b45e15
Cleaning up font directory, adding geomanist and cabin, and breaking …
skipjack Oct 10, 2016
ab5f337
Using new fonts in the logo, headers, and body text
skipjack Oct 10, 2016
14a089a
Removing various backgrounds in body content
skipjack Oct 10, 2016
a65310d
Removing the 40px padding for now (might have to come back to the sid…
skipjack Oct 10, 2016
5394d34
Simplifying the color scheme using @jhnns new logo colors and updatin…
skipjack Oct 10, 2016
1aa7afe
Adding react-headroom and updating the navigation component (@bebraw …
skipjack Oct 10, 2016
a205dec
Simplifying the contributors section
skipjack Oct 10, 2016
8b18921
Fixing parts of the page layout after recent changes
skipjack Oct 10, 2016
77b927f
Pointing users to develop instead of master so they see the most rece…
skipjack Oct 10, 2016
9492306
Cleaning up the sidebar styling
skipjack Oct 10, 2016
4c227d7
Updating padding for mobile page__content
skipjack Oct 10, 2016
da6952a
Merge branch 'feature/fonts-n-styles' of https://github.com/webpack/w…
skipjack Oct 10, 2016
598b924
Updating the base font declaration
skipjack Oct 11, 2016
0bf0c47
Adding the new icon and doing some cleanup in the Footer
skipjack Oct 11, 2016
e4453e2
Adding the new logo and doing some cleanup in the Navigation
skipjack Oct 11, 2016
60fc2fc
Adding a menu (hamburger) icon
skipjack Oct 12, 2016
88fc450
Refactoring the Site component and allowing interaction in the naviga…
skipjack Oct 12, 2016
99c60b0
Refactoring Navigation to allow toggling of the Sidebar
skipjack Oct 12, 2016
5de51b3
Updating Sidebar's displayed/visible class to follow BEM
skipjack Oct 12, 2016
2f22f88
Removing debug statement
skipjack Oct 12, 2016
34a39f1
Quick fix for the mobile sidebar anchor links
skipjack Oct 12, 2016
ed8e1a8
Tweaking the footer styling for mobile
skipjack Oct 12, 2016
2f20d93
Tweaking hacky sidebar styling
skipjack Oct 12, 2016
7dea15e
Making the Sidebar sticky and breaking out the Item component into a …
skipjack Oct 12, 2016
fe9d518
Fixing active behavior for Navigation links (display active throughou…
skipjack Oct 12, 2016
17b1bd4
Removing the Splash page images
skipjack Oct 13, 2016
0dcf7a5
Attempting to get images working in production
skipjack Oct 13, 2016
1187807
Removing react-headroom (temporarily)
skipjack Oct 13, 2016
f537fe2
Removing react-sticky (temporarily)
skipjack Oct 13, 2016
9e834d8
Fixing some issues with the Sidebar
skipjack Oct 13, 2016
940b4cb
Adding the favicon
skipjack Oct 13, 2016
89bfb97
Refactoring and simplifying the Logo component
skipjack Oct 14, 2016
df543ab
Updating the Navigation to use the updated Logo component (instead of…
skipjack Oct 14, 2016
6a95c83
Fixing table styling
skipjack Oct 14, 2016
cc46897
Merge branch 'develop' into feature/fonts-n-styles
skipjack Oct 14, 2016
e03357a
Some fixes
skipjack Oct 14, 2016
df327d6
Simplifying breakpoint as per @oliverturner's suggestion
skipjack Oct 14, 2016
e679eee
Tweaking logo styling as suggested
skipjack Oct 14, 2016
8893e72
Updating navigation link styling
skipjack Oct 14, 2016
80ad1e4
Updating the license
skipjack Oct 14, 2016
bb9111b
Fixing my username
skipjack Oct 14, 2016
1d124e4
Updating the styling of markdown headers and bold text to make them p…
skipjack Oct 14, 2016
7e56187
Another attempt at an assets fix
skipjack Oct 14, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions components/container/container-style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,4 @@
width: 100%;
max-width: map-get($screens, large);
margin: 0 auto;

@include break(large) {
padding-right: 40px;
}
}
14 changes: 2 additions & 12 deletions components/contributors/contributors-style.scss
Original file line number Diff line number Diff line change
@@ -1,19 +1,9 @@
.contributor {
display: inline-block;
margin-top:1em;
margin-right: 1em;

&:last-of-type {
margin-right: 0;
}

img {
height: 80px;
border-radius: 3px;
}

span {
display: block;
text-align: center;
font-size: 0.8em;
height: 50px;
}
}
5 changes: 2 additions & 3 deletions components/contributors/contributors.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ import './contributors-style';
export default ({contributors}) => {
return (
<div className="contributors">
<h4>Contributors</h4>
<h3>Contributors:</h3>
<div className="contributors__list">
{
(contributors || []).map((contributor) => (
<a key={ contributor }
className="contributor"
href={ `https://github.com/${contributor}` }>
<img src={ `https://github.com/${contributor}.png?size=80` } />
<span>{ contributor }</span>
<img src={ `https://github.com/${contributor}.png?size=50` } />
</a>
))
}
Expand Down
8 changes: 4 additions & 4 deletions components/cube/cube-style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,20 +59,20 @@

&--light {
.cube__outer .cube__face:after {
background:transparentize(map-get($colors, concrete), 0.8);
background:transparentize(map-get($colors, malibu), 0.6);
}

.cube__inner .cube__face:after {
background:transparentize(map-get($colors, tussock), 0.4);
background:transparentize(map-get($colors, denim), 0.2);
}

&:hover {
.cube__outer .cube__face:after {
background:transparentize(map-get($colors, white), 0.8);
background:transparentize(map-get($colors, malibu), 0.7);
}

.cube__inner .cube__face:after {
background:transparentize(map-get($colors, lynch), 0.6);
background:map-get($colors, denim);
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions components/logo/logo-style.scss
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
@import 'vars';

@import url(https://fonts.googleapis.com/css?family=Averia+Sans+Libre:300);

.logo {
position:relative;
display:inline-block;

&__text {
font-size:1.3em;
font-family:'Averia Sans Libre';
font-family:'Geomanist', 'Century Gothic', sans-serif;
font-weight:500;
letter-spacing:1px;
margin-left:1.75em;
line-height:1.4;
transition:color 250ms;
Expand All @@ -30,11 +30,11 @@

&--light {
.logo__text {
color:map-get($colors, concrete);
color:map-get($colors, alto);
}

&:hover .logo__text {
color:map-get($colors, parchment);
color:map-get($colors, white);
}
}
}
}
3 changes: 1 addition & 2 deletions components/navigation/navigation-style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
@import 'mixins';
@import 'functions';

.navigation {
.headroom {
flex: 0 0 auto;

transition: background 250ms;
background: map-get($colors, mine-shaft);
}
Expand Down
47 changes: 23 additions & 24 deletions components/navigation/navigation.jsx
Original file line number Diff line number Diff line change
@@ -1,34 +1,33 @@
import React from 'react';
import Headroom from 'react-headroom';
import Link from '../link/link';
import Container from '../container/container';
import Logo from '../logo/logo';
import './navigation-style';

export default ({ home = '/', pages, onToggleNav }) => (
<div className="navigation">
<Container>
<div className="navigation__inner">
<button id="menu-btn" className="navigation__mobilebtn" onClick={onToggleNav}>
Open navigation
</button>
<Link className="navigation__logo" to="/">
<Logo theme="light" />
</Link>
<Headroom className="navigation">
<Container className="navigation__inner">
<button id="menu-btn" className="navigation__mobilebtn" onClick={onToggleNav}>
Open navigation
</button>
<Link className="navigation__logo" to="/">
<Logo theme="light" />
</Link>

<nav className="navigation__links">
{
pages.map((link, i) => (
<Link
key={ `navigation__link${i}` }
className="navigation__link"
activeClassName="navigation__link--active"
to={ `/${link.url}` }>
{ link.title }
</Link>
))
}
</nav>
</div>
<nav className="navigation__links">
{
pages.map((link, i) => (
<Link
key={ `navigation__link${i}` }
className="navigation__link"
activeClassName="navigation__link--active"
to={ `/${link.url}` }>
{ link.title }
</Link>
))
}
</nav>
</Container>
</div>
</Headroom>
);
19 changes: 10 additions & 9 deletions components/page/page-style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,24 @@
@import 'functions';

.page {
position: relative;
flex: 1 0 auto;

display: flex;
}

position: relative;
// XXX: Temporary hack to fix sidebar width
.page div:first-of-type {
flex:1;
}

.page__content {
overflow-x: hidden;
width: 100%;
padding: 0.5em;
padding: 1.5em 1em;

@media (min-width: map-get($screens, medium)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to simply use

.page__content {
  ...
  @include break {
    ...
  }
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixing now.

flex: 3;

padding: 1.5em;
background: map-get($colors, white);
}
}

Expand All @@ -29,14 +30,14 @@
@include break {
position: absolute;
display: block;
top: 1.5em;
right: calc(40px + 1.5em);
top: 1.4em;
right: 1.75em;
font-size: getFontSize(-1);
text-transform: uppercase;
color: map-get($colors, lynch);
color: map-get($colors, denim);
}

&:hover {
color: map-get($colors, chatham);
color: map-get($colors, malibu);
}
}
2 changes: 1 addition & 1 deletion components/page/page.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Contributors from '../contributors/contributors';
import './page-style';

export default ({ section, page }) => {
let edit = `https://github.com/webpack/webpack.js.org/edit/master/content/${page.url}.md`;
let edit = `https://github.com/webpack/webpack.js.org/edit/develop/content/${page.url}.md`;

return (
<Container className="page">
Expand Down
24 changes: 10 additions & 14 deletions components/sidebar/sidebar-style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,6 @@
.sidebar {
position: relative;
flex: 1;

// Disabled as interactive generates a div parent (need to attach the code somewhere)
// This needs a better fix (no way to eliminate the div)
/*
@include break {
max-width: 25%;
background: transparentize(map-get($colors, white), 0.5);
}
*/
}

.sidebar__inner {
Expand All @@ -29,13 +20,14 @@
overflow-x: hidden;
padding: 1.5em;
background: map-get($colors, emperor);
color: map-get($colors, dusty-grey);
color: map-get($colors, alto);
z-index: 1;

@include break {
position: static;
transform: none;
width: 100%;
max-height:none;
background: transparent;
color: map-get($colors, emperor);
}
Expand All @@ -51,11 +43,10 @@

.sidebar-item {
font-size: getFontSize(-1);
margin-bottom: 0.5em;
margin-bottom: 0.75em;

&__title {
font-weight: 400;
text-transform: uppercase;
text-decoration: none;
color: inherit;

Expand All @@ -80,11 +71,11 @@
display:none;
list-style: none;
padding: 0;
margin: 0.25em 0 1em;
margin: 0.5em 0 1em;
}

&__anchor {
margin: 0;
margin:0.25em 0;

a {
display: inline-block;
Expand All @@ -110,5 +101,10 @@
.sidebar-item__anchors {
display:block;
}

.sidebar-item__toggle {
margin-left:-2px;
transform:rotate(180deg) translateX(1px);
}
}
}
Binary file added fonts/geomanist-medium.woff
Binary file not shown.
Binary file added fonts/geomanist-medium.woff2
Binary file not shown.
Binary file added fonts/geomanist-regular.woff
Binary file not shown.
Binary file added fonts/geomanist-regular.woff2
Binary file not shown.
Binary file removed fonts/icons.eot
Binary file not shown.
23 changes: 0 additions & 23 deletions fonts/icons.svg

This file was deleted.

Binary file removed fonts/icons.ttf
Binary file not shown.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
"preact-compat": "^3.6.0",
"react": "^15.3.2",
"react-dom": "^15.3.2",
"react-headroom": "^2.1.2",
"react-router": "^2.8.1"
}
}
18 changes: 18 additions & 0 deletions styles/fonts.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
@import url(https://fonts.googleapis.com/css?family=Ubuntu+Mono);
@import url(https://fonts.googleapis.com/css?family=Cabin:400,400i,600,600i);

@font-face {
font-family: 'Geomanist';
src: url('../fonts/geomanist-medium.woff2') format('woff2'),
url('../fonts/geomanist-medium.woff') format('woff');
font-weight: 500;
font-style: normal;
}

@font-face {
font-family: 'Geomanist';
src: url('../fonts/geomanist-regular.woff2') format('woff2'),
url('../fonts/geomanist-regular.woff') format('woff');
font-weight: 400;
font-style: normal;
}
Loading