-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Updates and Fixes #225
Merged
Merged
Changes from 23 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
2a5ebe9
Cleaning up font directory, adding geomanist and cabin, and breaking …
skipjack 2c37ebe
Using new fonts in the logo, headers, and body text
skipjack 49383e1
Removing various backgrounds in body content
skipjack 7562d81
Removing the 40px padding for now (might have to come back to the sid…
skipjack b6fc76c
Simplifying the color scheme using @jhnns new logo colors and updatin…
skipjack f6c908e
Adding react-headroom and updating the navigation component (@bebraw …
skipjack 1e0c59b
Simplifying the contributors section
skipjack 9e6d257
Fixing parts of the page layout after recent changes
skipjack fdf1f79
Pointing users to develop instead of master so they see the most rece…
skipjack b9ccd3a
Cleaning up the sidebar styling
skipjack a33a92a
Updating padding for mobile page__content
skipjack 0b45e15
Cleaning up font directory, adding geomanist and cabin, and breaking …
skipjack ab5f337
Using new fonts in the logo, headers, and body text
skipjack 14a089a
Removing various backgrounds in body content
skipjack a65310d
Removing the 40px padding for now (might have to come back to the sid…
skipjack 5394d34
Simplifying the color scheme using @jhnns new logo colors and updatin…
skipjack 1aa7afe
Adding react-headroom and updating the navigation component (@bebraw …
skipjack a205dec
Simplifying the contributors section
skipjack 8b18921
Fixing parts of the page layout after recent changes
skipjack 77b927f
Pointing users to develop instead of master so they see the most rece…
skipjack 9492306
Cleaning up the sidebar styling
skipjack 4c227d7
Updating padding for mobile page__content
skipjack da6952a
Merge branch 'feature/fonts-n-styles' of https://github.com/webpack/w…
skipjack 598b924
Updating the base font declaration
skipjack 0bf0c47
Adding the new icon and doing some cleanup in the Footer
skipjack e4453e2
Adding the new logo and doing some cleanup in the Navigation
skipjack 60fc2fc
Adding a menu (hamburger) icon
skipjack 88fc450
Refactoring the Site component and allowing interaction in the naviga…
skipjack 99c60b0
Refactoring Navigation to allow toggling of the Sidebar
skipjack 5de51b3
Updating Sidebar's displayed/visible class to follow BEM
skipjack 2f22f88
Removing debug statement
skipjack 34a39f1
Quick fix for the mobile sidebar anchor links
skipjack ed8e1a8
Tweaking the footer styling for mobile
skipjack 2f20d93
Tweaking hacky sidebar styling
skipjack 7dea15e
Making the Sidebar sticky and breaking out the Item component into a …
skipjack fe9d518
Fixing active behavior for Navigation links (display active throughou…
skipjack 17b1bd4
Removing the Splash page images
skipjack 0dcf7a5
Attempting to get images working in production
skipjack 1187807
Removing react-headroom (temporarily)
skipjack f537fe2
Removing react-sticky (temporarily)
skipjack 9e834d8
Fixing some issues with the Sidebar
skipjack 940b4cb
Adding the favicon
skipjack 89bfb97
Refactoring and simplifying the Logo component
skipjack df543ab
Updating the Navigation to use the updated Logo component (instead of…
skipjack 6a95c83
Fixing table styling
skipjack cc46897
Merge branch 'develop' into feature/fonts-n-styles
skipjack e03357a
Some fixes
skipjack df327d6
Simplifying breakpoint as per @oliverturner's suggestion
skipjack e679eee
Tweaking logo styling as suggested
skipjack 8893e72
Updating navigation link styling
skipjack 80ad1e4
Updating the license
skipjack bb9111b
Fixing my username
skipjack 1d124e4
Updating the styling of markdown headers and bold text to make them p…
skipjack 7e56187
Another attempt at an assets fix
skipjack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,9 @@ | ||
.contributor { | ||
display: inline-block; | ||
margin-top:1em; | ||
margin-right: 1em; | ||
|
||
&:last-of-type { | ||
margin-right: 0; | ||
} | ||
|
||
img { | ||
height: 80px; | ||
border-radius: 3px; | ||
} | ||
|
||
span { | ||
display: block; | ||
text-align: center; | ||
font-size: 0.8em; | ||
height: 50px; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,33 @@ | ||
import React from 'react'; | ||
import Headroom from 'react-headroom'; | ||
import Link from '../link/link'; | ||
import Container from '../container/container'; | ||
import Logo from '../logo/logo'; | ||
import './navigation-style'; | ||
|
||
export default ({ home = '/', pages, onToggleNav }) => ( | ||
<div className="navigation"> | ||
<Container> | ||
<div className="navigation__inner"> | ||
<button id="menu-btn" className="navigation__mobilebtn" onClick={onToggleNav}> | ||
Open navigation | ||
</button> | ||
<Link className="navigation__logo" to="/"> | ||
<Logo theme="light" /> | ||
</Link> | ||
<Headroom className="navigation"> | ||
<Container className="navigation__inner"> | ||
<button id="menu-btn" className="navigation__mobilebtn" onClick={onToggleNav}> | ||
Open navigation | ||
</button> | ||
<Link className="navigation__logo" to="/"> | ||
<Logo theme="light" /> | ||
</Link> | ||
|
||
<nav className="navigation__links"> | ||
{ | ||
pages.map((link, i) => ( | ||
<Link | ||
key={ `navigation__link${i}` } | ||
className="navigation__link" | ||
activeClassName="navigation__link--active" | ||
to={ `/${link.url}` }> | ||
{ link.title } | ||
</Link> | ||
)) | ||
} | ||
</nav> | ||
</div> | ||
<nav className="navigation__links"> | ||
{ | ||
pages.map((link, i) => ( | ||
<Link | ||
key={ `navigation__link${i}` } | ||
className="navigation__link" | ||
activeClassName="navigation__link--active" | ||
to={ `/${link.url}` }> | ||
{ link.title } | ||
</Link> | ||
)) | ||
} | ||
</nav> | ||
</Container> | ||
</div> | ||
</Headroom> | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
@import url(https://fonts.googleapis.com/css?family=Ubuntu+Mono); | ||
@import url(https://fonts.googleapis.com/css?family=Cabin:400,400i,600,600i); | ||
|
||
@font-face { | ||
font-family: 'Geomanist'; | ||
src: url('../fonts/geomanist-medium.woff2') format('woff2'), | ||
url('../fonts/geomanist-medium.woff') format('woff'); | ||
font-weight: 500; | ||
font-style: normal; | ||
} | ||
|
||
@font-face { | ||
font-family: 'Geomanist'; | ||
src: url('../fonts/geomanist-regular.woff2') format('woff2'), | ||
url('../fonts/geomanist-regular.woff') format('woff'); | ||
font-weight: 400; | ||
font-style: normal; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to simply use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, fixing now.