Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle hashbangs in javascript files #13961

Merged
merged 1 commit into from
Aug 10, 2021
Merged

handle hashbangs in javascript files #13961

merged 1 commit into from
Aug 10, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 10, 2021

implements https://github.com/tc39/proposal-hashbang
fixes vercel/next.js#27806

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

@sokra The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from azure (1 errors / 0 warnings) and appveyor (success) and fix these issues.

@ctjlewis
Copy link

Great work, TYSM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next does not have Node-like support for shebangs in entry points
3 participants