bump webassemblyjs #7732

xtuc · 2018-07-16T11:59:04Z

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

ref xtuc/webassemblyjs#407

webpack-bot · 2018-07-16T11:59:07Z

For maintainers only:

This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

webpack-bot · 2018-07-16T12:21:34Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

xtuc · 2018-07-16T19:47:00Z

Please do not merge this yet.

sokra · 2018-07-25T06:54:54Z

Ping me when this is ready to merge

lib/wasm/WebAssemblyGenerator.js

@@ -9,7 +9,6 @@ const Template = require("../Template");
 const WebAssemblyUtils = require("./WebAssemblyUtils");
 const { RawSource } = require("webpack-sources");

-const { shrinkPaddedLEB128 } = require("@webassemblyjs/wasm-opt");


…emblyjs11

xtuc · 2018-07-25T09:20:51Z

Alright @sokra, lgtm

sokra · 2018-07-25T09:55:30Z

yarn.lock

-    "@webassemblyjs/wasm-gen" "1.5.13"
-    "@webassemblyjs/wasm-parser" "1.5.13"
-    debug "^3.1.0"
+    "@babel/cli" "^7.0.0-beta.54"


babel should be a devDependency

sokra · 2018-07-25T10:00:34Z

yarn.lock

+  version "1.7.4"
+  resolved "https://registry.yarnpkg.com/@webassemblyjs/ieee754/-/ieee754-1.7.4.tgz#b58c92c364a954a027d7415adc1bf10dd74d7ac5"
+  dependencies:
+    "@xtuc/buffer" "^5.2.2"


node.js has a buildin Buffer.

This seem to be for browser build only. Bundlers usually bring their own polyfills for Buffer. Polyfilling is not the responsibility of a library. If it's only needed to local building of a browser bundle, make it a dev dependency.

Yes, that's right. Let me remove it.

sokra · 2018-07-25T10:01:09Z

yarn.lock

  version "7.0.0-beta.54"
  resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0-beta.54.tgz#0024f96fdf7028a21d68e273afd4e953214a1ead"
  dependencies:
    "@babel/highlight" "7.0.0-beta.54"

+"@babel/core@^7.0.0-beta.54":


should not be included

sokra · 2018-07-25T10:03:51Z

yarn.lock

-    "@webassemblyjs/ast" "1.5.13"
-    "@webassemblyjs/wast-parser" "1.5.13"
-    long "^3.2.0"
+"@xtuc/long@4.2.1":


Weird that you are forking packages just for ESM. This seems unnecessary to me. Why not using the original package?

Yeah the issue is that some bundler (Rollup) won't bundle any cjs require, so I had to ESM'ify some dependecies.

For now I preferred forking them to avoid loosing my time merging it upstream, but that's definitely the plan. Is that a blocker for this PR?

rollup has a commonjs plugin

@sokra I submited PRs the upstream repositories. Would you mind removing them in a following PR? so we can fix the current issues in Webpack. If that's ok to you i'll update the PR to be ready to be merged.

19h · 2018-08-27T09:43:45Z

Please merge this soon after @xtuc considers it final; the current implementation actively corrupts binaries in certain circumstances. (rustwasm/wasm-bindgen#753)

sokra

@xtuc/long should eventually merged into upstream, but we can use it for now.

xtuc · 2018-09-10T14:10:29Z

Please let me update webassemblyjs before merging this.

sokra · 2018-09-10T14:17:22Z

I updated it to 1.7.5

sokra · 2018-09-10T14:18:48Z

Do you want to cut a new release?

xtuc · 2018-09-10T14:20:16Z

Ah cool thanks, yeah I just released 1.7.6 (mostly changes to the interpreter, which is not used here).

webpack-bot · 2018-09-10T14:22:48Z

@xtuc Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

sokra · 2018-09-10T15:30:59Z

Thanks

xtuc added 2 commits July 16, 2018 13:56

chore: bump webassemblyjs 1.6.0

f744c4a

feat: remove LEB128 opt

b310b9b

webpack-bot added PR: unreviewed PR: CI-ok labels Jul 16, 2018

montogeek approved these changes Jul 16, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Jul 16, 2018

xtuc mentioned this pull request Jul 20, 2018

wasm-edit can trigger LEB128 warning, producing corrupt output xtuc/webassemblyjs#407

Closed

chore: bump webassemblyjs

59114c1

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels Jul 23, 2018

xtuc changed the title ~~[WIP] bump webassemblyjs~~ bump webassemblyjs Jul 23, 2018

xtuc mentioned this pull request Jul 23, 2018

wasm fails to decode when using webpack -p #7760

Closed

webpack-bot added PR: conflict and removed PR: CI-ok labels Jul 24, 2018

chore: bump webassemblyjs

8214d56

xtuc commented Jul 25, 2018

View reviewed changes

xtuc added 3 commits July 25, 2018 10:06

Merge remote-tracking branch 'upstream/master' into chore-bump-webass…

38c3403

…emblyjs11

fix: merging

075208d

feat: remove wasm-opt

c9d6ec1

webpack-bot added PR: CI-ok and removed PR: conflict labels Jul 25, 2018

sokra requested changes Jul 25, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Jul 25, 2018

luizirber added a commit to luizirber/wort-dnd that referenced this pull request Jul 27, 2018

temporary fix for webpack and webassembly (webpack/webpack#7732)

fe840e1

xtuc mentioned this pull request Aug 26, 2018

Wasm decoding failed: table index X out of bounds rustwasm/wasm-bindgen#753

Closed

xtuc mentioned this pull request Sep 9, 2018

Add ArrayBuffer fallback for #7918 #7983

Closed

sokra added 2 commits September 10, 2018 15:18

Merge branch 'master' into chore-bump-webassemblyjs11

e0e0061

bump webassemblyjs

52e1630

sokra approved these changes Sep 10, 2018

View reviewed changes

webpack-bot added the PR: reviewed-approved label Sep 10, 2018

chore: bump webassemblyjs

4e02cac

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Sep 10, 2018

sokra approved these changes Sep 10, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Sep 10, 2018

sokra merged commit de85978 into webpack:master Sep 10, 2018

xtuc deleted the chore-bump-webassemblyjs11 branch September 10, 2018 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump webassemblyjs #7732

bump webassemblyjs #7732

xtuc commented Jul 16, 2018

webpack-bot commented Jul 16, 2018

webpack-bot commented Jul 16, 2018

xtuc commented Jul 16, 2018

sokra commented Jul 25, 2018

This comment was marked as outdated.

xtuc commented Jul 25, 2018

sokra Jul 25, 2018

sokra Jul 25, 2018

xtuc Jul 25, 2018

sokra Jul 25, 2018

sokra Jul 25, 2018

xtuc Jul 25, 2018

sokra Jul 26, 2018

xtuc Aug 7, 2018 •

edited

Loading

19h commented Aug 27, 2018

sokra left a comment

xtuc commented Sep 10, 2018

sokra commented Sep 10, 2018

sokra commented Sep 10, 2018

xtuc commented Sep 10, 2018

webpack-bot commented Sep 10, 2018

sokra commented Sep 10, 2018

bump webassemblyjs #7732

bump webassemblyjs #7732

Conversation

xtuc commented Jul 16, 2018

webpack-bot commented Jul 16, 2018

webpack-bot commented Jul 16, 2018

xtuc commented Jul 16, 2018

sokra commented Jul 25, 2018

This comment was marked as outdated.

xtuc commented Jul 25, 2018

sokra Jul 25, 2018

Choose a reason for hiding this comment

sokra Jul 25, 2018

Choose a reason for hiding this comment

xtuc Jul 25, 2018

Choose a reason for hiding this comment

sokra Jul 25, 2018

Choose a reason for hiding this comment

sokra Jul 25, 2018

Choose a reason for hiding this comment

xtuc Jul 25, 2018

Choose a reason for hiding this comment

sokra Jul 26, 2018

Choose a reason for hiding this comment

xtuc Aug 7, 2018 • edited Loading

Choose a reason for hiding this comment

19h commented Aug 27, 2018

sokra left a comment

Choose a reason for hiding this comment

xtuc commented Sep 10, 2018

sokra commented Sep 10, 2018

sokra commented Sep 10, 2018

xtuc commented Sep 10, 2018

webpack-bot commented Sep 10, 2018

sokra commented Sep 10, 2018

xtuc Aug 7, 2018 •

edited

Loading