fix: add runtime field of jest config #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you please add something to the related fixture so we'll have some coverage? |
webpro
reviewed
May 15, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
This file shouldn't be added
There was a problem hiding this comment.
Thanks! I also asked for #639 (comment) - any chance you could work that in as well?
There was a problem hiding this comment.
I've missed this comment. Sure, I'll do it
There was a problem hiding this comment.
Maybe you've forgot to add the file? It doesn't seem to be in this branch yet.
decadef20
commented
May 21, 2024
| @@ -26,4 +26,5 @@ module.exports = { | |||
| ], | |||
| testResultsProcessor: 'jest-phabricator', | |||
| snapshotResolver: '<rootDir>/snapshotResolver.js', | |||
| runtime: '@side/jest-runtime', | |||
| }; | |||
|
There seems to be a failing test, any chance you could look into it? |
webpro
force-pushed
the
main
branch
3 times, most recently
from
13ba313
to
28f05f0
Compare
|
Is there still interest in wrapping up this pull request? |
webpro
force-pushed
the
main
branch
2 times, most recently
from
d692d08
to
7aa2f6d
Compare
Freakyty
approved these changes
Jun 20, 2024
webpro
force-pushed
the
main
branch
4 times, most recently
from
d91d007
to
d4121d9
Compare
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #603