Fix: Support Cypress configs with false value for e2e.supportFile and component.supportFile
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and `component.supportFile`
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 87c1167 |
|
Great catch! Thanks @THowland1 |
|
🚀 This pull request is included in v5.21.2. See Release 5.21.2 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress config can support the value of
falsefor both thee2e.supportFileandcomponent.supportFilesettingshttps://docs.cypress.io/guides/references/configuration#e2e
https://docs.cypress.io/guides/references/configuration#component
Because
falseis neither astringnorArray<string>, when transformed by the map in line 31,toEntryPatterntries to performspecifier.replace(/^(entry:)?/, 'entry:')which gives the errorTypeError: specifier.replace is not a function