Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use parseFragment instead of text node which breaks formatting #720

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

johenning
Copy link
Contributor

@johenning johenning commented Jul 9, 2024

Before (currently live https://knip.dev/reference/plugins/cucumber):
image

After:
image

Sidenote: The edit link that gets generated on these pages is misleading

Copy link

netlify bot commented Jul 9, 2024

‼️ Deploy request for knip rejected.

Name Link
🔨 Latest commit cb5e986

@webpro
Copy link
Collaborator

webpro commented Jul 9, 2024

Ouch! That looked ugly. Thanks! 🙏

@webpro webpro merged commit 3201c07 into webpro-nl:main Jul 9, 2024
@webpro
Copy link
Collaborator

webpro commented Jul 9, 2024

Sidenote: The edit link that gets generated on these pages is misleading

Thanks, will keep it in mind. Not sure if Astro/Starlight allows to get rid of it conditionally.

@webpro
Copy link
Collaborator

webpro commented Jul 11, 2024

🚀 This pull request is included in v5.25.2. See Release 5.25.2 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants