Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Regression: Adding exclusions to crawl broken in 1.10 beta #1777

Closed
ikreymer opened this issue May 1, 2024 · 0 comments · Fixed by #1778
Closed

[Bug]: Regression: Adding exclusions to crawl broken in 1.10 beta #1777

ikreymer opened this issue May 1, 2024 · 0 comments · Fixed by #1778
Assignees
@ikreymer
Labels
bug Something isn't working

Comments

@ikreymer
Copy link
Member

ikreymer commented May 1, 2024

Browsertrix Version

v1.10 beta 5

What did you expect to happen? What happened instead?

Adding exclusions during crawl results in a 500 error

Reproduction instructions

  1. Start crawl
  2. Attempt to add exclusions from the running crawl view on the workflow
  3. Observe exclusion not added, 500 error

Screenshots / Video

No response

Environment

No response

Additional details

The issue is on the backend, previous refactoring resulted in projection being used incorrectly, resulting in a type error. Fix forthcoming!
@ikreymer ikreymer added the bug Something isn't working label May 1, 2024
@ikreymer ikreymer self-assigned this May 1, 2024
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects May 1, 2024
@ikreymer ikreymer mentioned this issue May 1, 2024
Merged
@SuaYoo SuaYoo moved this from Todo to Implementing in Webrecorder Projects May 1, 2024
ikreymer added a commit that referenced this issue May 1, 2024
@ikreymer
regression fix: remove 'project' from non-raw crawl object getters, (#…
26abbdd 
…1778)

unnecessary projection prevents creating Crawl object, now removed

Fixes #1777
@github-project-automation github-project-automation bot moved this from Implementing to Done! in Webrecorder Projects May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikreymer ikreymer

Labels
bug Something isn't working
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

regression fix: remove 'project' from non-raw crawl object getters, webrecorder/browsertrix
1 participant
@ikreymer