Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writer: use 1.1 revisit profile when writing WARC/1.1 revisits, fixes #94 #96

Merged
merged 1 commit into from
Oct 11, 2019
Merged

writer: use 1.1 revisit profile when writing WARC/1.1 revisits, fixes #94 #96

merged 1 commit into from
Oct 11, 2019

Conversation

ikreymer
Copy link
Member

Fixes #94

@codecov
Copy link

codecov bot commented Oct 11, 2019 •
edited
Loading

Codecov Report

Merging #96 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #96      +/-   ##
=========================================
+ Coverage   98.49%   98.5%   +<.01%     
=========================================
  Files          18      18              
  Lines        1598    1600       +2     
  Branches      256     256              
=========================================
+ Hits         1574    1576       +2     
  Misses          4       4              
  Partials       20      20
Impacted Files Coverage Δ
warcio/recordbuilder.py 95.13% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3ceb7...1603b1f. Read the comment docs.

N0taN3rd
N0taN3rd approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@N0taN3rd N0taN3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ikreymer ikreymer changed the base branch from master to develop October 11, 2019 17:32
@ikreymer ikreymer merged commit 5715a9e into develop Oct 11, 2019
@ikreymer ikreymer deleted the revisit-profile-fix branch October 11, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N0taN3rd N0taN3rd N0taN3rd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikreymer @N0taN3rd