-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0 Dart client generation #3
Conversation
@VojtechVitek looking for reviews at your leisure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think this is excellent!
@austinmilt What a great contribution to the webrpc project. Thank you! 🎉
If you agree, I can get this into webrpc binary as an officially supported client.
I've never worked with Dart, so I won't be able to run/test this myself today.. but the tests suite looks very robust 👍
I would love to see this officially supported. Just FYI this version is what I'd consider a minimal implementation
|
@austinmilt it's a very great start :) Feel free to create issues for what you think is missing 👍 |
I made some issues but will likely wait to implement anything until/unless folks end up using the library (including myself :D) . |
https://github.com/webrpc/gen-dart/releases/tag/v0.1.1 Kudos to @austinmilt for implementing webrpc/gen-dart#3.
This PR adds Dart client code generation. It requires a single import into the client's codebase (documented in the README)
This version includes
main.go.tmpl
)types.go.tmpl
)tests/scripts/test.sh
andtests/test/reference_test.dart
)tests/test/custom_test.dart
).github/workflows/ci.yml
)_examples/flutter-go/
)Note this version ignores wide/large number truncation that occurs in web environments (i.e. Flutter web) (see webrpc/webrpc#283)