Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make endtoend-encryption work in Firefox (Feature-detect setCodecPreferences) #1612

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Make endtoend-encryption work in Firefox (Feature-detect setCodecPreferences) #1612

merged 2 commits into from
Jul 27, 2023

Conversation

jan-ivar
Copy link
Member

Description

  • Feature-detecting setCodecPreferences which is only needed for an optional feature.

Purpose

  • Make endtoend-encryption work in Firefox 117.

@jan-ivar
Copy link
Member Author

@henbos is this something we could merge? It makes the e2ee sample work with Firefox 117!

@jan-ivar
Copy link
Member Author

The datachannel timeouts seem unrelated?

@fippo fippo merged commit feb561e into webrtc:gh-pages Jul 27, 2023
2 of 3 checks passed
@fippo
Copy link
Collaborator

fippo commented Jul 27, 2023

Those tests are flaky, merged.

@fippo fippo mentioned this pull request Sep 5, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fippo fippo fippo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-ivar @fippo