Add video timing extension description and fix some old typos. #139
Conversation
… into video-timing-extension
ilyanikolaevskiy
changed the title
| - gem install html-proofer | ||
| - htmlproofer ./_site --only-4xx --allow-hash-href --alt-ignore '/.*/' | ||
| #- gem install html-proofer | ||
| #- htmlproofer ./_site --only-4xx --allow-hash-href --alt-ignore '/.*/' |
There was a problem hiding this comment.
Why was this disabled? There's been a lot of work done to make it work. See #131.
/cc @MirkoBonadei
There was a problem hiding this comment.
It was disabled because it somehow prevented me from adding a new page. Here is the mail I got from Mirko Bonadei:
It seems that it checks the generated link and it points to webrtc.org but since it hasn't published yet it gets the 404 Not Found.
That is annoying, please comment lines 25 and 26 in the .travis.yml file so you can deploy.
I will look into this in a few days.
There was a problem hiding this comment.
Ah ok, sorry. Just wanted to make sure someone's looking into it.
There was a problem hiding this comment.
Ilya: can we track this problem in an issue to ensure you don't forget about it?
There was a problem hiding this comment.
Henrik: Should I create a chromium/webrtc issue for this? Or should it be here on github?
There was a problem hiding this comment.
@ilyanikolaevskiy an issue here on Github seems to be the best fit.
|
|
||
| Name: "Video Timing" ; "RTP Header Extension for Video timing" | ||
|
|
||
| Formal name: <http://www.webrtc.org/experiments/rtp-hdrext/video-timing> |
There was a problem hiding this comment.
Maybe that was the overlooked problem which conflicted with html-proofer.
There was a problem hiding this comment.
Actually, it shouldn't be https. It's not a link but a name. Http is used in all such names, so it should be the same here.
|
@ilyanikolaevskiy I see the broken link check is still disabled (https://github.com/webrtc/webrtc-org/blob/gh-pages/.travis.yml). Could you enable it? |
|
@hkjellander, I tried to reenable it some time ago, and there were broken links. What should I do with them? Can I just remove them all? See: #143 |
|
Thanks for taking this on. Yes let's just remove the ones we cannot find a replacement for. I commented in PR #143 as well. |
|
Merged the change. Now html-proofer should be enabled. |
No description provided.