New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailChimp Integration: Empty API Key field autofills with password from browser #319

Closed
raamdev opened this Issue Nov 18, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@raamdev
Contributor

raamdev commented Nov 18, 2016

If you have a password saved in your browser autofill, saving the Comment Mail options with MailChimp Integration enabled but the MailChimp API Key field empty, you can end up with a browser-filled password in the field:

2016-11-17_20-22-51

We dealt with this same issue in Comet Cache recently; see websharks/comet-cache#741.


The fix that covers both Firefox and Chrome seems to be the following:

It looks like we can use autocomplete="off" in the <form> tag and Firefox will obey that. Then we can use autocomplete="new-password" in the individual fields, and Chrome will obey that

@raamdev raamdev added this to the Future Release milestone Nov 18, 2016

@raamdev raamdev removed the needs estimate label Nov 29, 2016

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Dec 2, 2016

jaswsinc

@jaswrks jaswrks referenced this issue Dec 2, 2016

Merged

PR: feature/319 #94

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 2, 2016

Next Release Changelog:

  • Bug Fix: Prevent browser autocomplete in Comment Mail options. See Issue #319.
@renzms

This comment has been minimized.

Contributor

renzms commented Dec 13, 2016

@jaswsinc @raamdev

Confirmed Working

screen shot 2016-12-13 at 3 24 09 pm

The MailChimp Integration fields do not autocomplete. 👍

raamdev added a commit that referenced this issue Dec 13, 2016

Phing release of v161213 with the following changes:
- **Bug Fix:** Prevent browser autocomplete in Comment Mail options. See [Issue #319](#319).
- **Bug Fix:** Searching by email address alone should always narrow to the search to that specific email address and not result in any fuzzy or fulltext matching. See [Issue #226](#226).
- **Bug Fix:** The conflict check for 'Subscribe to Comments Reloaded' was not working in the previous release; i.e., if you attempt to activate both Comment Mail and the 'Subscribe to Comments Reloaded' plugin at the same, this should result in a Dashboard warning. Fixed in this release. See [Issue #315](#315).
- **Bug Fix:** Notify 'Subscribe to Comments Reloaded' users about the comment form template being disabled under certain scenarios. See [Issue #314](#314).
- **Bug Fix:** Do not attempt to import 'Subscribe to Comments Reloaded' (StCR) settings if StCR is no longer installed, even if old StCR options exist in the database. See [Issue #294](#294).
- **Bug Fix** (Pro): Do not show SparkPost partner image when Mandrill is selected as the RVE handler. See [Issue #318](#318).
- **Bug Fix** (Pro): Conflict checks between lite and pro corrected. This was not working properly in the previous release; i.e., installing Comment Mail Pro when Comment Mail Lite is already running should result in Comment Mail Lite being deactivated automatically. See [Issue #270](#270).
- **New Feature:** It is now possible to manually process the outgoing mail queue. See: **WP Dashboard → Comment Mail → Mail Queue**. See also [Issue #282](#282).
- **New Feature** (Pro): In Comment Mail Pro it is now possible to enable/disable comment content clipping entirely; e.g., if you prefer that email notifications include the full original comment content in raw HTML instead of being clipped and displayed in the email as plain text. See: **WP Dashboard → Comment Mail → Config. Options → Email Notification Clips**. See also: [Issue #281](#281).
- **Accessibility:** This release improves screen reader accessibility by adding `aria-hidden="true"` to all FontAwesome icons. See [Issue #304](#304).
- **Accessibility:** This release improves screen reader accessibility by offering a new setting that allows a site owner to enable or disable select menu option enhancement via jQuery. Disabling select menu option enhancement has the benefit of improving accessibility for screen readers whenever accessibility is of more concern than presentation. See: **Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings**. See also [Issue #304](#304).
@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 13, 2016

Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#319)

@raamdev raamdev closed this Dec 13, 2016

@websharks websharks locked and limited conversation to collaborators Dec 13, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.