Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve breadcrumb component #81

Closed
paweljozwicki opened this issue Nov 16, 2022 · 2 comments
Closed

Improve breadcrumb component #81

paweljozwicki opened this issue Nov 16, 2022 · 2 comments
Assignees
@AdrianStaskiewicz
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@paweljozwicki
Copy link
Member

As an author, I want to have the possibility to choose an icon for the Breadcrumb element

Technical details:

  • there are a few other places where icons are used. Verify the possibility of moving some wider parts of dialogs to commons and include it in all the places.
@paweljozwicki paweljozwicki added enhancement New feature or request good first issue Good for newcomers labels Nov 16, 2022
@gfazek gfazek self-assigned this Nov 18, 2022
@gfazek gfazek mentioned this issue Nov 21, 2022
Closed
@gfazek
Copy link
Contributor

gfazek commented Nov 21, 2022

This issue is blocked by websight-io/starter#63.

@paweljozwicki
Copy link
Member Author

Blocking issue was resolved in WebSight CMS 1.11.1

@AdrianStaskiewicz AdrianStaskiewicz self-assigned this Apr 19, 2023
AdrianStaskiewicz added a commit that referenced this issue Apr 24, 2023
@AdrianStaskiewicz
#81 Added new breadcrumb element property - icon
871c1ad
AdrianStaskiewicz added a commit that referenced this issue Apr 26, 2023
@AdrianStaskiewicz
#81 Added new breadcrumb element property - icon (#170)
fd5b88a 
#81 Breadcrumb property: added new breadcrumb element property - icon
paweljozwicki added a commit that referenced this issue May 5, 2023
@paweljozwicki @AdrianStaskiewicz
@Rafal-DS @andrechern
Develop (#186)
65fa6be 
* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* WOS-170 merge fix

* WOS-170 one more fix

* WOS-183 Title Component - default state - missing H2 tag (renders H1 instead) (#183)

* Bugfix little fixes after review (#185)

* optimize imports and remove unused variables

* relative paths are better 👍

* init field definition for future task

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
martyna-ds added a commit that referenced this issue May 9, 2023
@martyna-ds @AdrianStaskiewicz
@Rafal-DS @andrechern @paweljozwicki
168 rte text color extension (#175)
948dc53 
* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #168 Add initial files

* #168 Add configuration files

* #168 Add color extension - draft, correct pom.xml

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #168 Correct configuration

* #168 Add new bulma-color module

* #168 Add new bulma-color module

* #168 Toggiling state

* #168 ColorDialog

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* #168 Colors list - dynamic css creation

* #168 Colors list - dynamic css creation

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* #168 Move color extension to extensions folder

* WOS-170 merge fix

* WOS-170 one more fix

* #168 Change /apps to /libs folder name

* #168 Move configuration to libs in backend

* #168 Move rte configuration to common

* #168 Corrections after pr, bulma fix

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Co-authored-by: Paweł Jóźwicki <pawel.jozwicki@ds.pl>
paweljozwicki added a commit that referenced this issue May 9, 2023
@martyna-ds @AdrianStaskiewicz
@Rafal-DS @andrechern @paweljozwicki
168 rte text color extension (#175)
3a53eb6 
* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #168 Add initial files

* #168 Add configuration files

* #168 Add color extension - draft, correct pom.xml

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #168 Correct configuration

* #168 Add new bulma-color module

* #168 Add new bulma-color module

* #168 Toggiling state

* #168 ColorDialog

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* #168 Colors list - dynamic css creation

* #168 Colors list - dynamic css creation

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* #168 Move color extension to extensions folder

* WOS-170 merge fix

* WOS-170 one more fix

* #168 Change /apps to /libs folder name

* #168 Move configuration to libs in backend

* #168 Move rte configuration to common

* #168 Corrections after pr, bulma fix

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Co-authored-by: Paweł Jóźwicki <pawel.jozwicki@ds.pl>
paweljozwicki added a commit that referenced this issue May 9, 2023
@paweljozwicki @Rafal-DS
@AdrianStaskiewicz @martyna-ds @andrechern
Develop (#190)
9fae5fd 
* Wos 185 title with subtitle (#188)

* WOS-185 added "add subtitle" checkbox

* WOS-185 subtitle config display

* WOS-185 fix tests

* WOS-185 added sly test

* WOS-185 fixed description

* WSIO-45 Navbar: added component template (#187)

* WSIO-45 Navbar: added component template

* WSIO-45 Navbar: applied changes requested during PR review

* 168 rte text color extension (#175)

* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #168 Add initial files

* #168 Add configuration files

* #168 Add color extension - draft, correct pom.xml

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #168 Correct configuration

* #168 Add new bulma-color module

* #168 Add new bulma-color module

* #168 Toggiling state

* #168 ColorDialog

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* #168 Colors list - dynamic css creation

* #168 Colors list - dynamic css creation

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* #168 Move color extension to extensions folder

* WOS-170 merge fix

* WOS-170 one more fix

* #168 Change /apps to /libs folder name

* #168 Move configuration to libs in backend

* #168 Move rte configuration to common

* #168 Corrections after pr, bulma fix

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Co-authored-by: Paweł Jóźwicki <pawel.jozwicki@ds.pl>

* Update minor version (#189)

* Wos 185 title with subtitle (#188)

* WOS-185 added "add subtitle" checkbox

* WOS-185 subtitle config display

* WOS-185 fix tests

* WOS-185 added sly test

* WOS-185 fixed description

* WSIO-45 Navbar: added component template (#187)

* WSIO-45 Navbar: added component template

* WSIO-45 Navbar: applied changes requested during PR review

* 168 rte text color extension (#175)

* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #168 Add initial files

* #168 Add configuration files

* #168 Add color extension - draft, correct pom.xml

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #168 Correct configuration

* #168 Add new bulma-color module

* #168 Add new bulma-color module

* #168 Toggiling state

* #168 ColorDialog

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* #168 Colors list - dynamic css creation

* #168 Colors list - dynamic css creation

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* #168 Move color extension to extensions folder

* WOS-170 merge fix

* WOS-170 one more fix

* #168 Change /apps to /libs folder name

* #168 Move configuration to libs in backend

* #168 Move rte configuration to common

* #168 Corrections after pr, bulma fix

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Co-authored-by: Paweł Jóźwicki <pawel.jozwicki@ds.pl>

* Update minor version (#189)

---------

Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: martyna-ds <120561838+martyna-ds@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrianStaskiewicz AdrianStaskiewicz

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gfazek @AdrianStaskiewicz @paweljozwicki