Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTE Text color extension #168

Closed
4 tasks
paweljozwicki opened this issue Apr 24, 2023 · 0 comments · Fixed by #175
Closed
4 tasks

RTE Text color extension #168

paweljozwicki opened this issue Apr 24, 2023 · 0 comments · Fixed by #175
Assignees
@martyna-ds
Labels
enhancement New feature or request

Comments

@paweljozwicki
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We need the possibility to change the text color in RTE.

Screenshot 2023-04-24 at 11 58 45

Describe the solution you'd like

  • UI component for RTE that allows choosing a color
  • Plugin component for RTE that allows adding a specific class to the text
  • Configuration that defines components with available colors and calls setting a proper class
  • Configuration should contain colors defined in https://bulma.io/documentation/helpers/color-helpers/ (default, light and dark)

Describe alternatives you've considered
Setting just a text color instead of class.

Additional context
Using classes can provide some problems like:

  • showing text color in the editor,
  • switching between colors (changing classes)
  • might not be supported by existing TipTap extensions, so we might need to implement our own
  • ...

Setting just a text color might not be the best solution but it can be a first step before some more general solution.
@paweljozwicki paweljozwicki added the enhancement New feature or request label Apr 24, 2023
martyna-ds added a commit that referenced this issue Apr 24, 2023
@martyna-ds
#168 Add initial files
452a46b
martyna-ds added a commit that referenced this issue Apr 25, 2023
@martyna-ds
#168 Add configuration files
609eed9
martyna-ds added a commit that referenced this issue Apr 25, 2023
@martyna-ds
#168 Add color extension - draft, correct pom.xml
50a41ed
martyna-ds added a commit that referenced this issue Apr 26, 2023
@martyna-ds
#168 Correct configuration
84984ab
martyna-ds added a commit that referenced this issue Apr 27, 2023
@martyna-ds
#168 Add new bulma-color module
6a97875
martyna-ds added a commit that referenced this issue Apr 27, 2023
@martyna-ds
#168 Add new bulma-color module
4aa2636
martyna-ds added a commit that referenced this issue Apr 27, 2023
@martyna-ds
#168 Toggiling state
34ffefb
martyna-ds added a commit that referenced this issue Apr 27, 2023
@martyna-ds
#168 ColorDialog
231da4e
martyna-ds added a commit that referenced this issue Apr 28, 2023
@martyna-ds
#168 Colors list - dynamic css creation
3cb8371
martyna-ds added a commit that referenced this issue Apr 28, 2023
@martyna-ds
#168 Colors list - dynamic css creation
88d4818
@martyna-ds martyna-ds linked a pull request Apr 28, 2023 that will close this issue
168 rte text color extension #175
Merged
5 tasks
martyna-ds added a commit that referenced this issue May 4, 2023
@martyna-ds
#168 Move color extension to extensions folder
a2f5009
martyna-ds added a commit that referenced this issue May 4, 2023
@martyna-ds
#168 Change /apps to /libs folder name
784838e
martyna-ds added a commit that referenced this issue May 4, 2023
@martyna-ds
#168 Move configuration to libs in backend
dc183d5
martyna-ds added a commit that referenced this issue May 5, 2023
@martyna-ds
#168 Move rte configuration to common
0421e53
martyna-ds added a commit that referenced this issue May 9, 2023
@martyna-ds
#168 Corrections after pr, bulma fix
7078ed3
martyna-ds added a commit that referenced this issue May 9, 2023
@martyna-ds @AdrianStaskiewicz
@Rafal-DS @andrechern @paweljozwicki
168 rte text color extension (#175)
948dc53 
* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #168 Add initial files

* #168 Add configuration files

* #168 Add color extension - draft, correct pom.xml

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #168 Correct configuration

* #168 Add new bulma-color module

* #168 Add new bulma-color module

* #168 Toggiling state

* #168 ColorDialog

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* #168 Colors list - dynamic css creation

* #168 Colors list - dynamic css creation

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* #168 Move color extension to extensions folder

* WOS-170 merge fix

* WOS-170 one more fix

* #168 Change /apps to /libs folder name

* #168 Move configuration to libs in backend

* #168 Move rte configuration to common

* #168 Corrections after pr, bulma fix

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Co-authored-by: Paweł Jóźwicki <pawel.jozwicki@ds.pl>
paweljozwicki added a commit that referenced this issue May 9, 2023
@martyna-ds @AdrianStaskiewicz
@Rafal-DS @andrechern @paweljozwicki
168 rte text color extension (#175)
3a53eb6 
* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #168 Add initial files

* #168 Add configuration files

* #168 Add color extension - draft, correct pom.xml

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #168 Correct configuration

* #168 Add new bulma-color module

* #168 Add new bulma-color module

* #168 Toggiling state

* #168 ColorDialog

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* #168 Colors list - dynamic css creation

* #168 Colors list - dynamic css creation

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* #168 Move color extension to extensions folder

* WOS-170 merge fix

* WOS-170 one more fix

* #168 Change /apps to /libs folder name

* #168 Move configuration to libs in backend

* #168 Move rte configuration to common

* #168 Corrections after pr, bulma fix

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Co-authored-by: Paweł Jóźwicki <pawel.jozwicki@ds.pl>
paweljozwicki added a commit that referenced this issue May 9, 2023
@paweljozwicki @Rafal-DS
@AdrianStaskiewicz @martyna-ds @andrechern
Develop (#190)
9fae5fd 
* Wos 185 title with subtitle (#188)

* WOS-185 added "add subtitle" checkbox

* WOS-185 subtitle config display

* WOS-185 fix tests

* WOS-185 added sly test

* WOS-185 fixed description

* WSIO-45 Navbar: added component template (#187)

* WSIO-45 Navbar: added component template

* WSIO-45 Navbar: applied changes requested during PR review

* 168 rte text color extension (#175)

* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #168 Add initial files

* #168 Add configuration files

* #168 Add color extension - draft, correct pom.xml

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #168 Correct configuration

* #168 Add new bulma-color module

* #168 Add new bulma-color module

* #168 Toggiling state

* #168 ColorDialog

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* #168 Colors list - dynamic css creation

* #168 Colors list - dynamic css creation

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* #168 Move color extension to extensions folder

* WOS-170 merge fix

* WOS-170 one more fix

* #168 Change /apps to /libs folder name

* #168 Move configuration to libs in backend

* #168 Move rte configuration to common

* #168 Corrections after pr, bulma fix

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Co-authored-by: Paweł Jóźwicki <pawel.jozwicki@ds.pl>

* Update minor version (#189)

* Wos 185 title with subtitle (#188)

* WOS-185 added "add subtitle" checkbox

* WOS-185 subtitle config display

* WOS-185 fix tests

* WOS-185 added sly test

* WOS-185 fixed description

* WSIO-45 Navbar: added component template (#187)

* WSIO-45 Navbar: added component template

* WSIO-45 Navbar: applied changes requested during PR review

* 168 rte text color extension (#175)

* #165 Added icon position property to the button component adn adjuste… (#166)

* #165 Button component: added possibility to define two icons (left and right)

* #168 Add initial files

* #168 Add configuration files

* #168 Add color extension - draft, correct pom.xml

* #145 created extensions module and moved tableservice and tableview i… (#167)

* #145 created extensions module and moved tableservice and tableview into it

* #145 updated readme file

* #163 Added new button modifier option - inverted button (#169)

#163 Button component:  added new modifier option - inverted button

* #81 Added new breadcrumb element property - icon (#170)

#81 Breadcrumb property: added new breadcrumb element property - icon

* #168 Correct configuration

* #168 Add new bulma-color module

* #168 Add new bulma-color module

* #168 Toggiling state

* #168 ColorDialog

* #164 added alignment config option for level item component (#171)

* #164 added alignment config option for level item component

* #164 now the alignment works in nested containers too

* #164 unused constant

* #164 optimize imports

* #164 import order

* WOS-168 Content Text weight (#173)

* #168 Colors list - dynamic css creation

* #168 Colors list - dynamic css creation

* Wos 173 apps to libs (#180)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component (#181)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-178 init content for hero component

* WOS-176 added container style config to navbar component (#182)

* WOS-173 move apps -> libs

* WOS-173 paths in sources apps -> libs

* WOS-176 added container style config to navbar component

* WOS-176 change after review

* #170 added vertical alignment for level item component (#177)

* #168 Move color extension to extensions folder

* WOS-170 merge fix

* WOS-170 one more fix

* #168 Change /apps to /libs folder name

* #168 Move configuration to libs in backend

* #168 Move rte configuration to common

* #168 Corrections after pr, bulma fix

---------

Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Co-authored-by: Paweł Jóźwicki <pawel.jozwicki@ds.pl>

* Update minor version (#189)

---------

Co-authored-by: Rafal-DS <121929316+Rafal-DS@users.noreply.github.com>
Co-authored-by: AdrianStaskiewicz <34780625+AdrianStaskiewicz@users.noreply.github.com>
Co-authored-by: martyna-ds <120561838+martyna-ds@users.noreply.github.com>
Co-authored-by: andrechern <119608077+andrechern@users.noreply.github.com>
Co-authored-by: Rafał Ziemniewski <rafal.ziemniewski@ds.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martyna-ds martyna-ds

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

168 rte text color extension websight-io/kyanite
2 participants
@paweljozwicki @martyna-ds