Commits on Jun 24, 2021

1. [minor] Simplify the closing handshake …

   - When the socket emits the `'end'` event, do not call `socket.end()`.
     End only the `receiver` stream.
   - Do not wait for a close frame to be received and sent before calling
     `socket.end()`. Call it right after the close frame is written.
   - When the `receiver` stream emits `'finish'`, send a close frame if no
     close frame is received.
   
   The assumption is that the socket is allowed to be half-open. On the
   server side this is always true (unless the user explicitly sets the
   `allowHalfOpen` property of the socket to `false`). On the client side
   the user might use an agent so we set `socket.allowHalfOpen` to `true`
   when the `http.ClientRequest` object emits the `'upgrade'` event.
   
   Refs: #1899

   

   lpinca committed Jun 24, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 916adf5
   • Browse repository at this point

   Copy the full SHA

   916adf5 View commit details

   Browse the repository at this point in the history

2. [fix] Do not unconditionally set the ready state to -2 …

   If we're already closing, then we shouldn't move into the new -2 ready
   state (i.e. closing-because-the-remote-end-closed). We're already
   closing, we shouldn't go back to a state that allows sending another
   close frame.

   

   pimterry authored and lpinca committed Jun 24, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for e83f377
   • Browse repository at this point

   Copy the full SHA

   e83f377 View commit details

   Browse the repository at this point in the history

3. [test] Add tests for various close edge cases

   

   pimterry authored and lpinca committed Jun 24, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 1d923fa
   • Browse repository at this point

   Copy the full SHA

   1d923fa View commit details

   Browse the repository at this point in the history