-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support permessage-deflate extension #409
Conversation
woaaaaahhh @_@ |
@nkzawa I see that it fails on node 0.8 but overall the code looks good and I have no problem merging this and bumping ws to |
Wow, nice work. You beat me to it. |
@3rd-Eden Thank you for reviewing. I will fix failing tests ASAP. |
<3 @nkzawa |
@3rd-Eden Fixed. Please check again. |
Support permessage-deflate extension
Thanks <3 -- Releasing as 0.6 |
The implementation seems to be really unstable, it's causing primus's test suite to fail and people have been reporting bugs of thrown errors as well: primus/primus#319 I'm going to release a 0.6.1 which disables permessagedeflate by default. |
Ah, I'm sorry. I will tackle the problem. |
@nkzawa Is there any intention or plan to add support for |
This PR adds the permessage-deflate extension support to the module including the following features:
memLevel
(zlib)Things not included in the PR:
x-webkit-frame-deflate
(which Safari supports)If these features also are required, I'm ready to add them.
Related: #34, socketio/socket.io#1148