Status code must be 1006 if the socket is closed without having recei… #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved a close control frame
|
Works like a charm! |
|
Any ETA to get this merged in please? |
|
@jtblin I made a temporary fork which I'm currently using for my own project - If this fix is important to your case, you can use it in the meantime: https://www.npmjs.com/package/sc-ws - I guess the merge/release cycle for ws is slow because of the sheer number of dependants - Risk management. |
|
👍 |
3rd-Eden
added a commit
that referenced
this pull request
Dec 21, 2015
Status code must be 1006 if the socket is closed without having recei…
|
Thanks for the contribution, will be availabe in the next 1.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ved a close control frame