Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve cursor on input line and display received messages from the line start. #123

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Preserve cursor on input line and display received messages from the line start. #123

merged 2 commits into from
Jun 10, 2020

Conversation

mahdi-shojaee
Copy link
Contributor

@mahdi-shojaee mahdi-shojaee commented Jun 10, 2020

Thanks for this useful tool.
Currently, we cannot type correctly while receiving messages from the server. With each message received from the server, the current cursor position will reset. Received messages also not displaying correctly.

Connected (press CTRL+C to quit)
    < tick
 < tick
     < tick
    < tick
    < tick
   < tick
     < tick
    < tick
    < tick
> .erverrom sages fmessving receiwhile g typin

This PR fixed these two bugs also mentioned in Issues #46 and #84. The new output is this:

Connected (press CTRL+C to quit)
< tick
< tick
< tick
< tick
< tick
< tick
< tick
< tick
< tick
< tick
> typing while receiving messages from the server.

@mahdi-shojaee mahdi-shojaee changed the title Preserve cursor on input line and display server sent messages from the beginning of each line. Preserve cursor on input line and display received messages from the line start. Jun 10, 2020
@lpinca lpinca merged commit 938ee60 into websockets:master Jun 10, 2020
@lpinca
Copy link
Member

lpinca commented Jun 10, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants