feat!: parse layer hidden, transparency lock flags #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastelmind
added
type: bug
- Add `layer.isHidden` and `layer.isTransparencyLocked` flags (`isHidden` was previously `visible`, and was not exposed via TypeScript) - Improve logic for parsing layer flags (use bitwise OR, not toString) - Fix bug where the `isHidden` flag (previously `visible`) was being parsed incorrectly - Add test cases for the new flags (and update fixture)
pastelmind
force-pushed
the
feat-layer-flags
branch
from
ee82b96
to
6687bcb
Compare
dlehdanakf
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11
layer.isHiddenandlayer.isTransparencyLockedflags(
isHiddenwas previouslyvisible, and was not exposed via TypeScript)Note that "transparency locked" does not equate "layer is locked". A fully locked layer always has transparency lock set, but not vice versa.