feature: Implement additional ImageResources #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoiatael
force-pushed
the
feature/image-resources
branch
from
aeb9758
to
24d5408
Compare
|
Ready for review :) |
pastelmind
approved these changes
Oct 18, 2022
Comment on lines
+269
to
+278
| /** | ||
| * Reads unsigned 4-byte fixed-point number. | ||
| * 32 bits in 16.16 setup | ||
| * https://github.com/meltingice/psd.js/blob/333dd1467452a3353018c2856e3e4fb0e07d0025/lib/psd/resources/resolution_info.coffee#L10 | ||
| */ | ||
| readFixedPoint32bit(): number { | ||
| const int = this.read("u32"); | ||
| return int / (1 << 16); | ||
| } | ||
|
|
There was a problem hiding this comment.
The number of ways Adobe came up with to store numbers never ceases to surprise me. Good work👏
alexspevak
pushed a commit
to opendesigndev/psd-ts
that referenced
this pull request
Jan 16, 2023
* [feature] Implement missing ImageResources * Add tests for extra properties * Simplify readFixedPoint32Bit computation * Make DimensionUnit, ResolutionUnit part of API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Over the past month we implemented some features in our fork for the upcoming OpenDesign new release. We didn't have time to discuss them with you properly, so let me know if you want these features or not - in case you do, I'll properly refactor the code and add tests :)
This is PR 2/3; implementing additional image resources: resolution info, global light properties.