Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing guide #57

Merged
merged 1 commit into from
Oct 17, 2022
Merged

docs: add contributing guide #57

merged 1 commit into from
Oct 17, 2022

Conversation

pastelmind
Copy link
Collaborator

As per #51, but we're long overdue for a contributing guide anyway.

@sifatul Could you please check this and suggest any changes?

@pastelmind pastelmind self-assigned this Oct 15, 2022
@sifatul
Copy link
Contributor

sifatul commented Oct 16, 2022

@pastelmind description in the CONTRIBUTING.md is well written. All the major guides are already in there.
If you prefer you may add some minor guidelines for clean code and readability (which is not urgent at this moment anyway).

@pastelmind
Copy link
Collaborator Author

I'll take that as an approval! (Clean code is something we need to improve on ourselves, but you're right in that it's not the most urgent task right now)

@pastelmind pastelmind merged commit 2c144c3 into main Oct 17, 2022
@pastelmind pastelmind deleted the docs-contributing branch October 17, 2022 00:04
@pastelmind pastelmind linked an issue Oct 17, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper instructions for contributions is needed
2 participants