Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX polish #3

Closed
13 of 14 tasks
dcposch opened this issue Mar 4, 2016 · 10 comments
Closed
13 of 14 tasks

UX polish #3

dcposch opened this issue Mar 4, 2016 · 10 comments
Labels

Comments

@dcposch
Copy link
Contributor

dcposch commented Mar 4, 2016

  • Torrent list
    • Add ability to start and stop torrenting without deleting the torrent
    • Make the + button work
    • Add Blender Foundation torrents for demonstration
    • Play button should turn into a spinner if you click on it before the torrent is ready
  • Player controls
    • Switch from sequential to rarest strategy once the video has buffered far enough
    • Scrubbing
    • Cast buttons
    • Fullscreen toggle button, ESC to exit fullscreen
    • Letterboxing (video should be centered)
    • Platform polish (back button in title bar in OSX, over video on hover in Linux and Windows)
    • Hide the player controls if the mouse hasn't moved for a while
    • Don't hide the player controls when scrubbing, when moused over them, or when paused
  • Cross platform
    • Make it look nice on Ubuntu
    • Make it look nice on Windows
@ungoldman
Copy link
Contributor

Currently there are three actions for each torrent in the list -- chromecast, play, and delete.

The video functionality is cool but (currently) only works for single video files. I think a start/pause download button (which may conflict visually with the video play button) is more important since it applies to all types of downloads. I think it should also be more prominent in the visual hierarchy than the video controls.

So here is an emoji mockup:

Current:

title 📶 ▶️
0️⃣ % - 0️⃣ Peers - 0️⃣ B/s - 0️⃣ B/s

Proposed changes:

title ▶️
📶 🎦
0️⃣ % - 0️⃣ Peers - 0️⃣ B/s - 0️⃣ B/s

  • Download controls (first row) are available for all torrents
    • play button turns to pause when active
  • Playback controls (second row) are only visible for supported files

If this makes sense to you I can work on implementing it.

@ChrisMorrisOrg
Copy link
Contributor

Fullscreen is a bit of an issue in OS X at the moment, the back/forward and add torrent buttons are not accessible in fullscreen mode.

Perhaps having those buttons move into the chrome in fullscreen mode would work better?

@dcposch
Copy link
Contributor Author

dcposch commented Mar 6, 2016

@ChrisMorrisOrg i think that's fine. you can hit ESC once to get out of fullscreen, then ESC again (or click back) to return to the torrent list

the add button appears only when you're in the torrent list, not while you're playing a video

@feross
Copy link
Member

feross commented Mar 6, 2016

@dcposch What does the app look like on Ubuntu now? Can we check off "make it look nice on Ubuntu?" from the list?

@rom1504
Copy link
Member

rom1504 commented Mar 6, 2016

It looks okay in kubuntu currently, apart from #51

webtorrent app

@giuscri
Copy link
Contributor

giuscri commented Mar 6, 2016

I'd add that pressing the space bar should pause the video

@dcposch
Copy link
Contributor Author

dcposch commented Mar 7, 2016

@giuscri good call, i'll make it do that

@dcposch
Copy link
Contributor Author

dcposch commented Mar 7, 2016

@feross it looks good in standard Ubuntu. I commented on #51, I think it's NBD

giuscri added a commit to giuscri/webtorrent-app that referenced this issue Mar 7, 2016
giuscri added a commit to giuscri/webtorrent-app that referenced this issue Mar 7, 2016
@feross
Copy link
Member

feross commented Mar 8, 2016

Looks good on Windows.

screen shot 2016-03-07 at 6 20 44 pm

I just discovered some minor UX issues:

  • Don't resize window when player is opened if window is maximized. (Didn't find this because OS X doesn't have the notion of maximized windows, only fullscreen.)
  • Try hiding top menu buttons until user presses Alt
  • Leave fullscreen when player closes. (all OSs)

feross added a commit that referenced this issue Mar 8, 2016
@feross
Copy link
Member

feross commented Mar 20, 2016

Going to close this issue now.

@dcposch There's already an issue open on the webtorrent repo for the one remaining item.

'sequential' piece selection should be a better citizen: webtorrent/webtorrent#375

@feross feross closed this as completed Mar 20, 2016
@feross feross added the area/ux label Mar 20, 2016
@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants