Hide menu bar in full screen

[rom1504]

On ubuntu with kde. I don't know if it happens with other desktop environments

[giuscri]

Same on LXDE

[dcposch]

Looks fine on Ubuntu with Unity

Ubuntu is the standard desktop Linux, the most common by far.

The rabbit hole of alternative setups -- various distributions using LXDE, KDE, older versions of Gnome, xmonad, etc etc--goes pretty deep. I don't know if we want to support all that.

(If it can be done without hacks, I'm cool with it. However, we're calling the built-in Electron BrowserWindow.setFullScreen() function. This Just Works on the three standard desktops: Windows, OSX, and unmodified Ubuntu.)

[ungoldman]

It would be nice to support edge cases but @dcposch makes a very good point about the variety of linux distros. @rom1504 @giuscri I think PRs are welcome if you can come up with a solution but priority will probably be given to making sure it works as intended on the big three.

[rom1504]

playback works just fine on kubuntu. I'll try to figure out what is going wrong here. Maybe this can help https://github.com/mafintosh/playback/blob/67b9d034094b3fd4954fafdd5e156e8e44c39163/index.js#L131

[giuscri]

@ngoldman, to my understanding this might be a problem that has to be delegated to Electron's source code. I'll try to see if I have to skill to solve it and try a PR...

[dcposch]

👍