Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage video is blocked by Chrome (for autoplaying audio) #128

Closed
feross opened this issue Apr 19, 2018 · 1 comment
Closed

Homepage video is blocked by Chrome (for autoplaying audio) #128

feross opened this issue Apr 19, 2018 · 1 comment

Comments

@feross
Copy link
Member

feross commented Apr 19, 2018 •
edited
Loading

Chrome has changed their policy on autoplaying videos, as have other browsers.

Details here: https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

Chrome blocks the autoplay entirely if the video is not muted, which is causing the homepage video on https://webtorrent.io to stop working entirely in Chrome 66 since we're waiting for the video to start playing before we unhide it.

I believe this can be fixed if we mute the video.
This was referenced Apr 19, 2018
Closed
Closed
feross added a commit that referenced this issue Apr 19, 2018
@feross
Fix Homepage video is blocked by Chrome
7a611f1 
- First click unmutes video
- All further clicks play/pause the video

Fixes: #128
@feross feross mentioned this issue Apr 19, 2018
Merged
@feross
Copy link
Member Author

feross commented Apr 20, 2018

Just tested it on the deployed site. Works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@feross