Make "always choke seeders" optional #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
SilentBot1
requested changes
Apr 15, 2024
There was a problem hiding this comment.
This looks fine to me, outside of a two small changes. Please address the suggestion and get this new option to the docs, with a short blurb of what it does, and I'll be happy to approve this.
Co-authored-by: Brad Marsden <silentbot1@gmail.com>
SilentBot1
approved these changes
Apr 22, 2024
|
🎉 Congrats on getting your first pull request landed! |
|
Thank you :) |
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Turn "always choke seeders" into an option (enabled by default).
Which issue (if any) does this pull request address?
When disabled, the client won't choke other seeders while it's seeding.
Is there anything you'd like reviewers to focus on?
Although the average person wouldn't want to change this setting, it is useful for custom bittorrent extensions which would like to keep peers unchoked. I would appreciate a PR as my bittorrent extension still needs seeding clients to communicate.