-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NextJS-ify Friday BOT #112
Conversation
@lhr0909 I have updated more files, please feel free to comment if you have any suggestions. Thank you very much! |
Most of it looks good. The main issue I see right now is the use of aggregate root. Aggregate roots are mainly for maintaining a retrievable state from the event stream (think xstate context). So we generally don’t fire any external logic in the aggregate roots. The better place to do so is via the Event Handlers. |
Now I'm working on the latest two domain projects:
Please stay tuned. |
@lhr0909 This PR has been almost finished with lots of refactoring since your last review. It will be greatly appreciated if you can take a look at the latest version of the code, and any comments/suggestions are welcome! |
Refactoring: enable CQRS
Link to: