Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextJS-ify Friday BOT #112

Merged
merged 123 commits into from
Feb 27, 2022
Merged

NextJS-ify Friday BOT #112

merged 123 commits into from
Feb 27, 2022

Conversation

huan
Copy link
Member

@huan huan commented Jan 29, 2022

@huan
Copy link
Member Author

huan commented Jan 30, 2022

@lhr0909 I have updated more files, please feel free to comment if you have any suggestions.

Thank you very much!

@huan huan requested a review from lhr0909 January 30, 2022 18:21
@lhr0909
Copy link

lhr0909 commented Jan 31, 2022

Most of it looks good. The main issue I see right now is the use of aggregate root. Aggregate roots are mainly for maintaining a retrievable state from the event stream (think xstate context). So we generally don’t fire any external logic in the aggregate roots. The better place to do so is via the Event Handlers.

@huan
Copy link
Member Author

huan commented Feb 3, 2022

Now I'm working on the latest two domain projects:

  1. Update https://chatie.statuspage.io/ with CommunityDevelopersCount, MessagesReceivedCount, and MessagesSentCount. This should be a domain and it's a great practice for building this domain model
  2. Cross-post the messages between WeChat, QQ, WhatsApp, and Gitter channels. This should be a domain too, and by designing this model, it can help the Wechaty design to start thinking in a CQRS way.

Please stay tuned.

@huan huan marked this pull request as ready for review February 27, 2022 02:36
@huan
Copy link
Member Author

huan commented Feb 27, 2022

@lhr0909 This PR has been almost finished with lots of refactoring since your last review.

It will be greatly appreciated if you can take a look at the latest version of the code, and any comments/suggestions are welcome!

CC @windmemory @atorber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants