Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to use their self-generated extspam #142

Merged
merged 7 commits into from
Jul 21, 2021
Merged

Allow users to use their self-generated extspam #142

merged 7 commits into from
Jul 21, 2021

Conversation

fi6
Copy link
Contributor

@fi6 fi6 commented Jul 15, 2021

Nothing will change if they don't customize their token, but will allow those who wants to use the token to setup without changing the raw code

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fi6
Copy link
Contributor Author

fi6 commented Jul 20, 2021

@huan Is there anything that I need to change with this PR or is there anything left to do before I submit it? Looks like it's been some days but this is still under review.

huan
huan requested changes Jul 20, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry for the delay and thank you for adding this great feature to the UOS puppet!

It's so smart to reuse the token for this puppet.

Just one more thing: could you please also add docs to our README so that other users can learn how to specify the extspam when they are using this puppet?

It will be better if see can support the WECHATY_PUPPET_WECHAT_TOKEN environment variable so that it can be easy to be deployed.

@fi6
Copy link
Contributor Author

fi6 commented Jul 21, 2021 •
edited
Loading

added environment support and brief readme instructions
sorry I'm not used to pre-push hooks and have to revert the version bump in this way :(

@huan huan merged commit 53445f2 into wechaty:master Jul 21, 2021
@huan
Copy link
Member

huan commented Jul 21, 2021

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited fi6 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!

huan pushed a commit to wechaty/docusaurus that referenced this pull request Jul 23, 2021
@fi6
wechat puppet pr #142: customized extspam options (#1135)
da093d6 
* pr for wechat puppet: customized extspam options

wechaty/puppet-wechat#142

* uploaded avatar

* updated avatar

* Delete avatar.jpeg

* upload webp avatar

* Update fi6.md
@huan huan mentioned this pull request Jan 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fi6 @CLAassistant @huan