Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dirtyPayload() and hide others #114

Merged
merged 7 commits into from
Aug 19, 2020
Merged

add dirtyPayload() and hide others #114

merged 7 commits into from
Aug 19, 2020

Conversation

huan
Copy link
Member

@huan huan commented Aug 19, 2020

This PR is for supporting wechaty/puppet-service#43

And we have another discussion related to this PR at wechaty/grpc#79

@huan huan requested a review from a team as a code owner August 19, 2020 02:03
@huan huan requested a review from windmemory August 19, 2020 02:49
@huan
Copy link
Member Author

huan commented Aug 19, 2020

@windmemory Please help me to review this PR and let me know what you think.

Thank you very much!

Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, LGTM!

@windmemory windmemory merged commit 31b0770 into master Aug 19, 2020
@windmemory windmemory deleted the dirty_payload branch August 19, 2020 05:54
@huan
Copy link
Member Author

huan commented Aug 19, 2020

Thank you very much!

@huan
Copy link
Member Author

huan commented Aug 19, 2020

Link to wechaty/puppet-service#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants