Implement adapter between itchat and python-wechaty #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wj-Mcat
changed the title
huan
reviewed
Oct 16, 2021
| @@ -9,3 +9,4 @@ wechaty~=0.8.25 | |||
| loguru | |||
| node-semver~=0.8.1 | |||
| setuptools~=58.2.0 | |||
| itchat-uos | |||
There was a problem hiding this comment.
It's so great to see we have a dependency on Itchat UOS!
There was a problem hiding this comment.
Yes, I have made a small ding-dong receiving & sending code, and there are more details to be improved. I will complete it at next few weeks. ( No time to write code 😩 😩 😩 )
|
I’m so sorry that I haven’t reviewed this PR for a long time due to so many things in the school. |
|
Is this PR has any update? I'd like to see it to be merged soon, thanks! |
lyleshaw
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After review the itchat code, the
configured_replyfunc is the core function fetching the message & event. And calling the async function in sync function withrun_until_completemethod which can fix the calling problem.ding donghandling is ok now, but there are also some basic problem in this issue, eg: message container.@lyleshaw you can clone this pr to check out the detail, and you can get the final solution.