Add as.matrix to sim_TS #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If X only has one column, X[in1,] is a vector and the matrix multiplication fails.
Codecov Report
@@ Coverage Diff @@
## sim_edits #142 +/- ##
==========================================
Coverage 97.71% 97.71%
==========================================
Files 11 11
Lines 1223 1223
==========================================
Hits 1195 1195
Misses 28 28
Continue to review full report at Codecov.
|
Using only as.matrix() fails if there is only 1 year in a segment and there are multiple covariates. In that case, as.matrix(X[in1, ]) returns a matrix of n_covariates rows x 1 column, instead of a matrix of 1 row and n_covariates columns. This edit should fix that by forcing it into a matrix of the correct number of rows.
|
A simpler fix to avoid this issue entirely would be to stop R dropping the empty dimension when X_Eta <- X[in1, , drop = FALSE] %*% Eta[in2,]`If X_Eta <- X[in1, , drop = FALSE] %*% Eta[in2, , drop = FALSE] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If X only has one column, X[in1,] is a vector and the matrix multiplication fails. Adding the as.matrix seems to fix it.