fix bug where old users could see broken presence indicators on new users #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'ved added a commit that additionally fixes #15. |
This was referenced Nov 22, 2016
|
@xet7 do you have any thoughts on this? I've tested it a bunch locally and it looks good. I'd like to get this merged soon and ship the bugfix to our users. |
|
I'll test it soon and then merge it if it looks Ok. |
|
Ok this works, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24.
See the first example in the publish-relations performance notes.
The problem is that this callback can be called with the
board.membersvariable unset, for example when a board'smodifiedAtfield is changed. This can cause thepresencescursor to no longer work.