add support for source/destination ssh keys

[homerjam]

No description provided.

[wei]

Thanks for contributing, I definitely have encountered the same problem trying to set up ssh deploy keys on multiple repos as GitHub does not allow a key to be reused.

However, this is a major breaking change and will need to be test thoroughly with a major version bump, unless you are able to support the existing ssh_private_key usage?

Btw what are you using for linting README? Prettier? Thanks!!

[homerjam]

Yes Prettier! (I think)

Ok I will try to incorporate the ssh_private_key back in, maybe we can allow for the ssh keys to be optionally overridden by the new source and destination keys. Any thoughts? 🤔

[wei]

Yeah. You can probably just add the variable back in, and do

if [[ -n "$SSH_PRIVATE_KEY" ]]
then
  mkdir -p /root/.ssh
  echo "$SSH_PRIVATE_KEY" | sed 's/\\n/\n/g' > /root/.ssh/src_id_rsa
  chmod 600 /root/.ssh/src_id_rsa
  echo "$SSH_PRIVATE_KEY" | sed 's/\\n/\n/g' > /root/.ssh/dst_id_rsa
  chmod 600 /root/.ssh/dst_id_rsa
fi

before the src/dest ssh private keys to achieve that.

[wei]

One thing to look into: since the default id_rsa is no longer used, we need to make sure public ssh clone urls still work without a id_rsa.

[wei]

Thanks for putting it together and making the updates. I'll need to find some time to test it and will merge once everything is tested. Thank you!

In the meantime anyone interested in this feature should be able to use wei/git-sync@d4bce1c and subscribe to this issue for the release #.

[wei]

Thanks for your contribution. This feature is now available with wei/git-sync@v3 or wei/git-sync@v3.0.0 🎉