Skip to content
This repository has been archived by the owner on Jun 10, 2022. It is now read-only.

Helper to update the consumer offset foreach partition >>>WIP<<< #11

Merged
merged 1 commit into from
Apr 18, 2015

Conversation

dahateb
Copy link
Contributor

@dahateb dahateb commented Apr 10, 2015

This pull request is about the automatic updating of the offset in the consumer class, so that when fetch() is run in a loop, the offset for each partition is automatically increased. That way you will only get the newest messages.

@dahateb
Copy link
Contributor Author

dahateb commented Apr 10, 2015

Sorry this should have gone into my fork only, but you can review it anyway

nmred added a commit that referenced this pull request Apr 18, 2015
Helper to update the consumer offset foreach partition >>>WIP<<<
@nmred nmred merged commit 325af8b into weiboad:master Apr 18, 2015
@nmred
Copy link
Member

nmred commented Apr 18, 2015

thanks pull request! but travis report

[concat]
[concat]
[concat] Coding standards
[concat]
[concat] 1) Kafka/Protocol/Fetch/Helper/Consumer.php (trailing_spaces, braces, php_closing_tag, eof_ending)
[concat] 2) Kafka/Consumer.php (trailing_spaces, braces)
[concat]
[concat] Coding standards check failed!

I will fixed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants