Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fast-cgi client #181

Closed
wants to merge 1 commit into from
Closed

update fast-cgi client #181

wants to merge 1 commit into from

Conversation

f38905c2-2c1b-4352-b86e-337d11f2db86

fix bug in fcgi client

@codecov-io
Copy link

codecov-io commented Jul 7, 2019

Codecov Report

Merging #181 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   42.52%   42.49%   -0.03%     
==========================================
  Files          66       66              
  Lines        8179     8179              
==========================================
- Hits         3478     3476       -2     
- Misses       4323     4325       +2     
  Partials      378      378
Impacted Files Coverage Δ
provider/cgiProvider.go 0% <ø> (ø) ⬆️
endpoint/motanEndpoint.go 43.17% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349c1f7...43a365f. Read the comment docs.

@idevz
Copy link
Member

idevz commented Jul 9, 2019

感谢你的工作,我们很赞赏你在此做的工作,但是我们规定一般不依赖 fork 包,以防如果原包有更新后无法进一步升级同步,CGI 这个包还是比较重要,你能否把这个 PR 提到原包,然后我们重新更新原包依赖如何?

@f38905c2-2c1b-4352-b86e-337d11f2db86

beberlei/fastcgi-serve 有更新

@idevz
Copy link
Member

idevz commented Jul 31, 2019

感谢 @MarioKartMaster 我看 beberlei 明确表示他已经不再维护 beberlei/fastcgi-serve,你会持续维护吗?如果是这样的话,我们可以考虑使用你提供的版本。

@f38905c2-2c1b-4352-b86e-337d11f2db86

我是个Golang新手,不过如果可以的话我会长期维护这个包

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants