Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include LICENSE and NOTICE to the artifact jar #22

Closed
vlsi opened this issue Feb 14, 2020 · 4 comments
Closed

Please include LICENSE and NOTICE to the artifact jar #22

vlsi opened this issue Feb 14, 2020 · 4 comments

Comments

@vlsi
Copy link
Contributor

vlsi commented Feb 14, 2020

Hi, darklaf looks nice, and MIT is a great license choice (well, Apache-2.0 might be slightly less better), however, would you please add the relevant license to the resulting jar file?

For instance, https://repo1.maven.org/maven2/com/github/weisj/darklaf/1.3.3.4/ does not have license, so it would be a bit complicated for third-parties to comply with darklaf license.

  1. I suggest that darklaf.jar should include at least LICENSE for darklaf itself

  2. It looks like you include bits from IntelliJ platform (judging by NOTICE.txt). I guess that NOTICE.txt must be re-distributed with binary artifacts as well.

The suggested location is META-INF/LICENSE and or META-INF/NOTICE.

PS. Having a license in META-INF/LICENSE would simplify license compliance for the projects that bundle darklaf.

@weisJ
Copy link
Owner

weisJ commented Feb 14, 2020

Licenses are now included in the jar (ac9de65). Is this what you imagined?

@vlsi
Copy link
Contributor Author

vlsi commented Feb 14, 2020

Unfortunately, I can't verify that as the build fails for me with #2 (comment)

So I would probably wait for the new version.

@vlsi
Copy link
Contributor Author

vlsi commented Feb 15, 2020

darklaf-1.3.3.4.jar bundles org/pbjar/jxlayer/, so please bundle its license to the jar as well.

@vlsi
Copy link
Contributor Author

vlsi commented Feb 16, 2020

Fixed in #33

@vlsi vlsi closed this as completed Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants