Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Savvy 2.0 #305

Merged
merged 8 commits into from
Feb 19, 2021
Merged

Update to Savvy 2.0 #305

merged 8 commits into from
Feb 19, 2021

Conversation

jonathonl
Copy link
Contributor

There is a new version of the SAV file format and this update to the Savvy library adds support for the new file format while maintaining support for SAV v1, BCF, and VCF.

Notes about the upgrade:

  • SAV 2.0 is an extension of BCF, so it supports all BCF data types (including DS). This means that SAV files can be generated from imputed datasets that have DS but not HDS.
  • Indices for SAV 2.0 are appended to SAV files instead of being stored as separate S1R files. The option parsing in SAIGE_SPATest.R has been updated to remove the need for specifying --vcfFileIndex and --savFileIndex.
  • Both htslib and liblzma dependencies have been removed.
  • Savvy 2.0 drops support for TBI index files in favor of the more modern CSI index for BCF and VCF. Test files in extdata/input/ have been updated accordingly with bcftools index <input_file>.

@matuskosut
Copy link
Contributor

Hi @jonathonl, could you also create official release for new savvy such that it can be properly released on conda and used here as a dependency for Saige package? Currently the only official release I see is 1.3.0: https://github.com/statgen/savvy/releases

@jonathonl
Copy link
Contributor Author

Yeah, there are still a few things I'd like to tidy up before making a release. I expect it to happen in the next few days. I'll let you know when it's done.

@jonathonl
Copy link
Contributor Author

Savvy v2.0.0 is now released.

@weizhouUMICH weizhouUMICH merged commit c4e4c41 into weizhouUMICH:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants