-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-227): allow host networking via configuration #288
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sergeyberezansky and the rest of your teammates on Graphite |
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/23/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
31fc56b
to
9f6673b
Compare
fff5566
to
5875118
Compare
96f8120
to
ec1ed28
Compare
5875118
to
a422367
Compare
ec1ed28
to
a99ca64
Compare
a422367
to
f4ebe2a
Compare
a99ca64
to
a54f898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not workable. on CoreOS Controller does not start. Will continue tomorrow
f4ebe2a
to
05baecc
Compare
a54f898
to
d260764
Compare
05baecc
to
ec6fb4f
Compare
d260764
to
d308fe6
Compare
ec6fb4f
to
427e305
Compare
d308fe6
to
6868129
Compare
427e305
to
9d145cf
Compare
6868129
to
1390fe5
Compare
9d145cf
to
0a2db93
Compare
1390fe5
to
082ad5c
Compare
0a2db93
to
597fc57
Compare
082ad5c
to
8245393
Compare
597fc57
to
5758268
Compare
8245393
to
52c2054
Compare
5758268
to
a2a1190
Compare
52c2054
to
13f27d5
Compare
a2a1190
to
8514c07
Compare
13f27d5
to
7b3ac1d
Compare
8514c07
to
60f1999
Compare
7b3ac1d
to
7b1f73c
Compare
60f1999
to
4c8a15f
Compare
7b1f73c
to
29e20f8
Compare
Merge activity
|
4c8a15f
to
390839d
Compare
29e20f8
to
9b5cb62
Compare
9b5cb62
to
7eb7ad1
Compare
TL;DR
This pull request introduces a conditional configuration to enable
hostNetwork
support for thecsi-wekafsplugin
Helm chart. The changes involve adding conditional checks in the templates to apply thehostNetwork
settings based on the values provided.What changed?
controllerserver-statefulset.yaml
andnodeserver-daemonset.yaml
to applyhostNetwork
settings.hostNetwork
value is true.nodeserver-daemonset.yaml
to accommodate thehostNetwork
setup.How to test?
hostNetwork: true
in thevalues.yaml
file.hostNetwork
configuration.Why make this change?
This change is motivated by the need to support host networking for specific environments where pod networking might be insufficient or problematic, such as Weka clusters running on top of Kubernetes. Allowing conditional
hostNetwork
configuration provides greater flexibility and control over the networking setup of the CSI driver components.