fix(CSI-241): disregard sync_on_close in mountmap per FS #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/02/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
This was referenced Sep 2, 2024
sergeyberezansky
force-pushed
the
sergey/mount-map-no-sync
branch
from
9649f48
to
513312a
Compare
sergeyberezansky
force-pushed
the
sergey/custom-ca-cert
branch
from
edfa630
to
35fd62f
Compare
sergeyberezansky
force-pushed
the
sergey/mount-map-no-sync
branch
from
513312a
to
2336372
Compare
Merge activity
|
sergeyberezansky
changed the base branch from
sergey/custom-ca-cert
to
graphite-base/310
sergeyberezansky
force-pushed
the
sergey/mount-map-no-sync
branch
from
2336372
to
0a7f087
Compare
sergeyberezansky
force-pushed
the
sergey/mount-map-no-sync
branch
from
0a7f087
to
152354b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Introduced a new
AsMapKey()method forMountOptionsto create version-agnostic map keys.What changed?
AsMapKey()method to theMountOptionsstruct inmountoptions.go.MountOptionSyncOnClose) to be used as a map key.mounter.goto useAsMapKey()instead ofString()when accessing or modifying themountMap.How to test?
Covered by unit testing
Why make this change?
This change allows for more consistent handling of mount options across different versions of the Weka cluster / client. By excluding version-specific options like
MountOptionSyncOnClosefrom the map key, we can avoid unnecessary duplication of mounts and ensure that mounts with the same essential options are treated as identical, regardless of version-specific differences.