Add support for admin status sync #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xet7
added a commit
to wekan/wekan
that referenced
this pull request
Mar 6, 2019
Examples: LDAP_SYNC_ADMIN_STATUS=true, LDAP_SYNC_ADMIN_GROUP=group1,group2 Thanks to JulianJacobi and xet7 !
xet7
added a commit
to wekan/wekan
that referenced
this pull request
Mar 6, 2019
Examples: LDAP_SYNC_ADMIN_STATUS=true, LDAP_SYNC_ADMIN_GROUP=group1,group2 (7e451d9). Thanks to JulianJacobi and xet7.
|
Closes #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would adds the possibility to sync the status of the isAdmin flag based on ldap group membership.
Therefor i added two new configuration options:
LDAP_SYNC_ADMIN_STATUS: boolean flag to enable admin status sync
LDAP_SYNC_ADMIN_GROUPS: comma separated list of groups. If an ldap synced user ist member of any of this groups the admin flag will be set to true.
The sync check will performed on every login.
Additionally i've added a feature wich prevents the first user who logged in to the system automatically get root, even if he's not in a privileged group.
I think this pull request solves issue #19