Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-2722 Reintroduce incontainer testing to PRs #2747

Merged
merged 11 commits into from
Jun 24, 2022

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Jun 8, 2022

JIRA issue - https://issues.redhat.com/browse/WELD-2722

There are expected failures due to at least:

Other adjustments are needed in probe tests, servlet containers and presumably even tests-arquillian (those that are integration only?).
I will incrementally fix any failures I encounter and update this PR accordingly.

@manovotn manovotn changed the title Reintroduce incontainer testing to PRs WELD-2722 Reintroduce incontainer testing to PRs Jun 8, 2022
@manovotn
Copy link
Contributor Author

manovotn commented Jun 9, 2022

Also, WFLY seems to have merged EE 10 deps into its main build (instead of just preview) so we might be able to consume that instead.

@manovotn
Copy link
Contributor Author

The TCK failure is currently not reproducible locally and looks like some timing issue.
The incontainer failures are related to servlet testing and will need updates of API, core and Arq. tomcat container.

@starksm64
Copy link
Contributor

#2750 has the changes I sent a diff for just for reference.

…very mode ALL so that the resulting deployement is a bean archive.

This is similar to how Weld behaved when ALL was default discovery mode; JSF now requires CDI container to run in order to boot.
@manovotn
Copy link
Contributor Author

With recent push, I am able to get servlet tests pass with Tomcat

[INFO] Results:
[INFO] 
[WARNING] Tests run: 53, Failures: 0, Errors: 0, Skipped: 1

@manovotn
Copy link
Contributor Author

Recent failures in serialization tests are linked to wildfly/wildfly#15425

There are new serialization-friendlier classes used in WFLY and this causes CNFE for our serialization smoke tests.
This is because the new classes reside in WFLY's clustering module and we don't have access to the CL that loaded them from tests. I have yet to figure out how to bypass that.

@pferraro
Copy link
Contributor

Can you verify that wildfly/wildfly#15686 solves the problem?

@manovotn
Copy link
Contributor Author

Dropped a comment into your PR, it almost does the job :-)

@manovotn
Copy link
Contributor Author

Recent changes in wildfly/wildfly#15686 make the serialization tests pass again.
Once that PR gets merged, we should be able to get a green pass here as well (using nightly build of WFLY preview).

@manovotn
Copy link
Contributor Author

This PR now contains updates to docs WRT to servlet support.
WFLY PR has been merged, so starting tomorrow we should again have relevant CI results on PRs.

@manovotn manovotn marked this pull request as ready for review June 24, 2022 09:25
@manovotn
Copy link
Contributor Author

We are mostly green once again.
The failing TCKs seem flaky and I have seen them before (timeout interceptor tests). Locally they passed, so I'll have to look into those separately but they are definitely non-blocking.

@manovotn manovotn merged commit 9e0d5be into weld:master Jun 24, 2022
@manovotn manovotn deleted the addIncontainerTestingToPr branch June 24, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants