-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WELD-2722 Reintroduce incontainer testing to PRs #2747
Conversation
f28bea5
to
468a5c7
Compare
468a5c7
to
ab38697
Compare
Also, WFLY seems to have merged EE 10 deps into its main build (instead of just preview) so we might be able to consume that instead. |
The TCK failure is currently not reproducible locally and looks like some timing issue. |
#2750 has the changes I sent a diff for just for reference. |
…very mode ALL so that the resulting deployement is a bean archive. This is similar to how Weld behaved when ALL was default discovery mode; JSF now requires CDI container to run in order to boot.
4c1a05d
to
3d79ee2
Compare
With recent push, I am able to get servlet tests pass with Tomcat
|
…et testing by dynamically resolving BM.
0cf64c1
to
62f4893
Compare
Recent failures in serialization tests are linked to wildfly/wildfly#15425 There are new serialization-friendlier classes used in WFLY and this causes CNFE for our serialization smoke tests. |
Can you verify that wildfly/wildfly#15686 solves the problem? |
Dropped a comment into your PR, it almost does the job :-) |
e089f47
to
0a264cb
Compare
Recent changes in wildfly/wildfly#15686 make the serialization tests pass again. |
…. Jetty adapter is not executing the tests correctly
This PR now contains updates to docs WRT to servlet support. |
We are mostly green once again. |
JIRA issue - https://issues.redhat.com/browse/WELD-2722
There are expected failures due to at least:
Other adjustments are needed in probe tests, servlet containers and presumably even tests-arquillian (those that are integration only?).
I will incrementally fix any failures I encounter and update this PR accordingly.