Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-1689 InjectionServices.aroundInject() called twice #594

Closed
wants to merge 1 commit into from

Conversation

bafco
Copy link
Member

@bafco bafco commented Jun 10, 2014

No description provided.

@weld-tester
Copy link

Triggering build using a merge of 633e478 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor/

final SlimAnnotatedType<T> type, final InjectionTarget<T> injectionTarget) {
// Java EE component environment resource dependencies are injected first
Beans.injectEEFields(resourceInjectionsHierarchy, instance, ctx);
ResourceInjector.super.inject(instance, ctx, manager, type, injectionTarget);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way Beans.injectEEFields() will be called outside of InjectionContext.proceed(). Weld should perform all injections within InjectionContext.proceed().

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed '.run()' to '.proceed()', but it looks kind of... silly.

@weld-tester
Copy link

Triggering build using a merge of fa2036d on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor/

@weld-tester
Copy link

Build 567 is now running using a merge of fa2036d on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor/567

@weld-tester
Copy link

@weld-tester
Copy link

Triggering build using a merge of b90734a on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor/

@weld-tester
Copy link

Build 568 is now running using a merge of b90734a on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/Weld-2.x-pull-player-executor/568

@weld-tester
Copy link

@jharting
Copy link
Member

Merged, thanks!

@jharting jharting closed this Jun 17, 2014
@bafco bafco deleted the WELD-1689 branch June 17, 2014 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants