-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WELD-1689 InjectionServices.aroundInject() called twice #594
Conversation
Triggering build using a merge of 633e478 on branch master: |
final SlimAnnotatedType<T> type, final InjectionTarget<T> injectionTarget) { | ||
// Java EE component environment resource dependencies are injected first | ||
Beans.injectEEFields(resourceInjectionsHierarchy, instance, ctx); | ||
ResourceInjector.super.inject(instance, ctx, manager, type, injectionTarget); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way Beans.injectEEFields() will be called outside of InjectionContext.proceed(). Weld should perform all injections within InjectionContext.proceed().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed '.run()' to '.proceed()', but it looks kind of... silly.
Triggering build using a merge of fa2036d on branch master: |
Build 567 is now running using a merge of fa2036d on branch master: |
Build 567 outcome was FAILURE using a merge of fa2036d on branch master: |
Triggering build using a merge of b90734a on branch master: |
Build 568 is now running using a merge of b90734a on branch master: |
Build 568 outcome was SUCCESS using a merge of b90734a on branch master: |
Merged, thanks! |
No description provided.